Skip to content

[EXPERIMENTAL] AppSec snapshot generation with unreleased tracer#147

Draft
Strech wants to merge 9 commits into
mainfrom
experimental/appsec-snapshot-generation
Draft

[EXPERIMENTAL] AppSec snapshot generation with unreleased tracer#147
Strech wants to merge 9 commits into
mainfrom
experimental/appsec-snapshot-generation

Conversation

@Strech

@Strech Strech commented May 7, 2026

Copy link
Copy Markdown
Member

⚠️ Experimental — do not merge

Combines PR #144 (AppSec setup) with PR #146 (build layer from dd-trace-rb branch) to test snapshot generation with unreleased tracer code.

What's here

How to use

  1. Go to Actions → "update-snapshots" → Run workflow
  2. Select this branch
  3. Set git_ref to the dd-trace-rb branch with AppSec aws_lambda instrumentation
  4. Download snapshot artifacts when complete

🤖 Generated with Claude Code

@Strech Strech force-pushed the experimental/appsec-snapshot-generation branch from c392f42 to 10eb199 Compare May 19, 2026 10:58
@datadog-datadog-prod-us1

datadog-datadog-prod-us1 Bot commented May 19, 2026

Copy link
Copy Markdown

Pipelines

Fix all issues with BitsAI

⚠️ Warnings

🚦 9 Pipeline jobs failed

DataDog/datadog-lambda-rb | integration test (3.2, amd64)   View in Datadog   GitLab

🔧 Fix in code (Fix with Cursor). Integration tests failed due to log mismatch with snapshots across multiple functions including async-metrics_ruby and sync-metrics_ruby.

DataDog/datadog-lambda-rb | integration test (3.2, arm64)   View in Datadog   GitLab

🔧 Fix in code (Fix with Cursor). Integration tests failed due to log mismatch with existing snapshots for multiple functions.

build | integration-test (3.2)   View in Datadog   GitHub Actions

🔧 Fix in code (Fix with Cursor). Mismatch found between new log data and snapshot resulting in validation failures across multiple functions during integration testing.

View all 9 failed jobs.

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 7ccb199 | Docs | Datadog PR Page | Give us feedback!

@Strech Strech force-pushed the experimental/appsec-snapshot-generation branch from 10eb199 to e10625e Compare May 21, 2026 07:29
Strech and others added 8 commits May 21, 2026 10:46
Initialize AppSec context around each Lambda invocation, push request and
response events through the AppSec gateway, and record security events on
the aws.lambda span. The extension handles tag propagation to inferred spans.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Normalize raw AWS event payloads into a standard key set before
passing to DataContainer and Request. This removes v1/v2 detection
from Request and aligns with dd-trace-rb's simplified WAFAddresses
that consume standard keys.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Rename add_appsec_tags to tag_and_keep, move from create_context to
  on_start for visibility
- Pass cold_start flag from listener through to AppSec.on_start instead
  of tracking @oneshot_tags_sent module state
- Align guard clause with Rack: return unless trace && span
- Improve test quality: inline event values, use receive_messages,
  remove instance_variable_set for @request, relax unrelated assertions

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
* Fix cleanup of AppSec on unsuccessful start
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@Strech Strech force-pushed the experimental/appsec-snapshot-generation branch from e10625e to c74528a Compare May 27, 2026 19:39
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant