Skip to content

ci(regressions): restore column-aware SARIF comparison after byte→UTF-16 transition #915

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
robertohuertasm-datadog merged 1 commit into from
May 21, 2026
Merged

ci(regressions): restore column-aware SARIF comparison after byte→UTF-16 transition #915

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 3 additions & 32 deletions .github/scripts/check-regressions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,33 +22,7 @@ const parseFile = (filepath) => {
const current = {};
current.message = i.message;
current.ruleId = i.ruleId;
// ------------------------------------------------------------------
// IMPORTANT (TEMPORARY): strip `startColumn` / `endColumn` from the region.
//
// PR #914 changes the kernel from emitting 1-based UTF-8 byte columns to
// 1-based UTF-16 code-unit columns (matching LSP / VS Code / SARIF v2.1).
//
// While that PR is in review, `main` still emits byte columns and the
// feature branch emits UTF-16 columns. The regression check compares
// results as JSON strings, so it would flag every violation that lives
// on a line containing a non-ASCII character as a "removed + added"
// pair — same file, same rule, same line; only the column number drifts
// by N (where N is the number of multibyte chars before the position).
//
// To unblock CI for #914 we compare by
// (file, ruleId, message, startLine, endLine)
// and intentionally ignore columns. This is a one-shot loosening for
// the byte→UTF-16 transition. A stacked follow-up PR will restore
// `startColumn` / `endColumn` to the comparison key once #914 lands on
// `main` (at which point both runs are on UTF-16 columns again and
// column-level regression detection becomes meaningful again).
// ------------------------------------------------------------------
const { startColumn: _startCol, endColumn: _endCol, ...regionWithoutColumns } =
i.locations[0].physicalLocation.region;
current.physicalLocation = {
...i.locations[0].physicalLocation,
region: regionWithoutColumns,
};
current.physicalLocation = i.locations[0].physicalLocation;
results.push(current);
}

Expand Down Expand Up @@ -81,16 +55,13 @@ const main = async () => {
let table1 = [];

if (count1 > 0 || count2 > 0) {
// Location display only shows `startLine-endLine`. Columns are
// intentionally omitted to match the comparison key (see `parseFile`
// above for the full rationale on the byte→UTF-16 transition).
for (const item of diff1) {
const json = JSON.parse(item);
table1.push([
{ data: json.physicalLocation.artifactLocation.uri },
{ data: json.message.text },
{ data: json.ruleId },
{ data: `${json.physicalLocation.region.startLine}-${json.physicalLocation.region.endLine}` },
{ data: `${json.physicalLocation.region.startLine}:${json.physicalLocation.region.startColumn}-${json.physicalLocation.region.endLine}:${json.physicalLocation.region.endColumn}` },
{ data: dupes1[json.ruleId] },
]);
}
Expand All @@ -103,7 +74,7 @@ const main = async () => {
{ data: json.physicalLocation.artifactLocation.uri },
{ data: json.message.text },
{ data: json.ruleId },
{ data: `${json.physicalLocation.region.startLine}-${json.physicalLocation.region.endLine}` },
{ data: `${json.physicalLocation.region.startLine}:${json.physicalLocation.region.startColumn}-${json.physicalLocation.region.endLine}:${json.physicalLocation.region.endColumn}` },
{ data: dupes2[json.ruleId] },
]);
}
Expand Down
Loading