Repository navigation
Use planned Iceberg column stats on the dd-source Arrow 59 pin - #34
Draft
alexanderbianchi wants to merge 4 commits into
Draft
alexanderbianchi wants to merge 4 commits into
alexanderbianchi wants to merge 4 commits into
Conversation
Exports datafusion_distributed::ColumnByteStatisticsProvider so an embedder can register it in a StatisticsRegistry and keep column-byte estimates through grouping keys and inner joins. It is not registered automatically by Iceberg. (cherry picked from commit 29248e7)
Request column statistics from the scan (iceberg-rust with_column_stats, apache/iceberg-rust#3424) and summarize them from the planned FileScanTasks instead of re-reading manifests, so a scan reads its manifests once. Point iceberg and iceberg-storage-opendal at DataDog/iceberg-rust 9354b42 (upstream main on Arrow 59), the revision dd-source uses, and patch datafusion-iceberg's apache/iceberg-rust dependency to the same source so FileScanTask is one type. The retained metrics stay on each task, so they are also serialized to workers with the file list and counted by the planning memory reservation: iceberg-rust has no way to drop them from a planned task. (cherry picked from commit db8db25)
Signed-off-by: alex.bianchi <alex.bianchi@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on
676f79b, the DFD revision pinned by dd-source main and by dd-source#196245. Keeps the three existing stats commits through78f47d1, including single-pass eager scan statistics andColumnByteStatisticsProvider.The only change on top of that tested stack is a dependency bump: the direct dependencies, workspace patch and lockfile now use DataDog/iceberg-rust@7fda03019, matching dd-source#196245. That revision already contains apache/iceberg-rust#3424. No Iceberg cherry-pick or DataFusion 56 upgrade.
Validation:
cargo tree --lockedresolves one Iceberg revision, DataFusion 55.0.0 and Arrow 59.3.0. Thestatisticsandnested_column_statisticsintegration suites (21 tests) and thecolumn_byte_statisticsprovider tests (5 tests) pass with--locked.