Repository navigation
fix: align the distributed connector and predicate converter on one Iceberg revision - #37
Open
alexanderbianchi wants to merge 1 commit into
Open
alexanderbianchi wants to merge 1 commit into
alexanderbianchi wants to merge 1 commit into
Conversation
Signed-off-by: alex.bianchi <alex.bianchi@datadoghq.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pin the distributed connector, storage adapter, and test fixtures to DataDog/iceberg-rust at
7fda0301, which includes apache/iceberg-rust#3739. The connector takes its predicate converter from DataDog/datafusion-iceberg at4b4ec3cb, so the converter returns aPredicatefrom that same Iceberg crate. Consumers using this revision no longer need to patch Apache's Iceberg git source to unify the two types.Validation:
cargo test --locked -p datafusion-distributed-iceberg --test filter_pushdownpassed all five tests. Only manifests and the lockfile changed in this fork.