Sync feature/client-side-stats with develop#2900
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8c86577dc5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| // own uploads (preventing recursion) and other Datadog tooling that may run in the same | ||
| // process (e.g. `DatadogSDKTesting`'s CI Visibility uploader, which would otherwise pollute | ||
| // interception expectations via the global `__NSCFLocalSessionTask.resume` swizzle in tests). | ||
| return request?.value(forHTTPHeaderField: URLRequestBuilder.HTTPHeader.ddAPIKeyHeaderField) != nil |
There was a problem hiding this comment.
When an app makes its own instrumented URLSession request with a DD-API-KEY header (for example to a custom/proxy Datadog endpoint or any backend that uses that header name), this now returns before the RUM/Trace handlers run, so the request is neither tracked as a resource nor receives trace headers. The previous DD-REQUEST-ID check was limited to SDK-built uploads; please also constrain this skip to SDK/intake requests (e.g. request-id and/or known intake hosts) instead of the API-key header alone.
Useful? React with 👍 / 👎.
tienquocbui
force-pushed
the
feature/client-side-stats
branch
from
bb6e850 to
d3bd54a
Compare
1 participant
Merge latest develop into the feature branch to pick up recent fixes (including NetworkInstrumentationFeature crash fix and shadow-review workflow removal).