Skip to content

[NOJIRA] [CHORE] Remove ruby-version from benchmarks#1249

Merged
sbarrio merged 2 commits into
developfrom
sbarrio/fix/remove-ruby-version-from-benchmarks
Apr 20, 2026
Merged

[NOJIRA] [CHORE] Remove ruby-version from benchmarks#1249
sbarrio merged 2 commits into
developfrom
sbarrio/fix/remove-ruby-version-from-benchmarks

Conversation

@sbarrio
Copy link
Copy Markdown
Contributor

@sbarrio sbarrio commented Apr 14, 2026

What does this PR do?

Removes the ruby-version file from the benchmarks app, which was forcing rbenv to use 3.4.4.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

Copilot AI review requested due to automatic review settings April 14, 2026 15:37
@sbarrio sbarrio requested a review from a team as a code owner April 14, 2026 15:37
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes the benchmarks app’s Ruby version pin so local Ruby version managers (e.g., rbenv) are no longer forced to use Ruby 3.4.4 when working in that subdirectory.

Changes:

  • Deleted benchmarks/.ruby-version to stop pinning Ruby 3.4.4 for the benchmarks app.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@sbarrio sbarrio self-assigned this Apr 16, 2026
@sbarrio sbarrio changed the title [CHORE] Remove ruby-version from benchmarks [NOJIRA] [CHORE] Remove ruby-version from benchmarks Apr 17, 2026
@sbarrio sbarrio merged commit c630998 into develop Apr 20, 2026
11 checks passed
@sbarrio sbarrio deleted the sbarrio/fix/remove-ruby-version-from-benchmarks branch April 20, 2026 09:23
@cdn34dd cdn34dd mentioned this pull request Apr 29, 2026
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants