[RUM-9272] Add configurable time for classifying resources for TNS metric#835
Merged
sbarrio merged 1 commit intoApr 4, 2025
Conversation
fbb8158 to
3ab1116
Compare
Member
marco-saia-datadog
left a comment
There was a problem hiding this comment.
Looks good! My only suggestion is to add a few tests on the React Native layer as well.
Contributor
Author
Agree, will do! |
Member
|
An iOS check is also failing: |
Contributor
Author
Ah, of course, I renamed it but didn't change the test. On it! |
…m thresholds on TNS
7da80eb to
4637a8f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds a new config property called
initialResourceThreshold, which allows users to set the maximum time threshold (counting from view start, in seconds) inside of which a resource should be considered for the "Time to Network Settled" metric.Motivation
Exposing custom TNS settings for clients.
Additional notes
RN config

iOS custom TimeBasedNetworkSettledPredicate set

Android custom initialResourceIdentifier set

Review checklist (to be filled by reviewers)