RUM-8410 update the way session id is propagated#853
Merged
Conversation
Datadog ReportBranch report: ✅ 0 Failed, 669 Passed, 1 Skipped, 4.07s Total Time |
xgouchet
force-pushed
the
xgouchet/RUM-8410/propagate_session_headers
branch
from
0174e74 to
a1376cb
Compare
marco-saia-datadog
approved these changes
Apr 18, 2025
Member
marco-saia-datadog
left a comment
marco-saia-datadog
left a comment
There was a problem hiding this comment.
Great! I have added a unit test to check this behaviour. Does it look good to you?
Comment on lines
+1006
to
+1007
| const resourceContext = tracingContext.getRumResourceContext(); | ||
| expect(resourceContext['baggage']).toBeUndefined(); |
Member
There was a problem hiding this comment.
@xgouchet I am explicitly checking that we are not injecting the RUM Session ID in the Resource Context, as this is the current behaviour.
marco-saia-datadog
approved these changes
Apr 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the way we propagate the Session id using baggage instead of tracecontext/tags