[RUM-9771] Fix rum sessionIdListener for new architecture#865
Merged
cdn34dd merged 1 commit intoMay 6, 2025
Merged
Conversation
cdn34dd
changed the title
sessionIdListener for new architecturesessionIdListener for new architecture
Comment on lines
64
to
73
| static initialize = async ( | ||
| configuration: DdSdkReactNativeConfiguration | ||
| ): Promise<void> => { | ||
| // Register listeners before anything else to avoid events being skipped | ||
| registerRumSessionIdListener(); | ||
|
|
||
| await DdSdkReactNative.initializeNativeSDK(configuration, { | ||
| initializationModeForTelemetry: 'LEGACY' | ||
| }); | ||
|
|
||
| DdSdkReactNative.enableFeatures(configuration); | ||
| }; | ||
|
|
Member
There was a problem hiding this comment.
I believe this leads to the session ID listener to never be registered when using DatadogProvider.
Datadog ReportBranch report: ✅ 0 Failed, 669 Passed, 1 Skipped, 3.81s Total Time |
cdn34dd
force-pushed
the
carlosnogueira/RUM-9771/fix-event-emitter-event-new-arch
branch
2 times, most recently
from
1052cce to
f1e5381
Compare
sbarrio
reviewed
May 5, 2025
marco-saia-datadog
approved these changes
May 6, 2025
sbarrio
approved these changes
May 6, 2025
- Load turbo/native module conditionally for usage in EventEmitter init - Improve TS types
cdn34dd
force-pushed
the
carlosnogueira/RUM-9771/fix-event-emitter-event-new-arch
branch
from
f1e5381 to
fe6e340
Compare
cdn34dd
deleted the
carlosnogueira/RUM-9771/fix-event-emitter-event-new-arch
branch
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes bug where event emitter listener for rum session id does not receive events on RN new architecture, due to the fact that we're accessing the native module from the wrong place.