[CHORE] Update SDK and Example Projects to RN 0.79#870
Closed
marco-saia-datadog wants to merge 5 commits into
Closed
[CHORE] Update SDK and Example Projects to RN 0.79#870marco-saia-datadog wants to merge 5 commits into
marco-saia-datadog wants to merge 5 commits into
Conversation
cdn34dd
approved these changes
May 8, 2025
sbarrio
reviewed
May 9, 2025
sbarrio
reviewed
May 9, 2025
| /** | ||
| * Sets the user information. | ||
| * @param extraUserInfo: The additional information. (To set the id, name or email please user setUserInfo). | ||
| * @param extraInfo The additional information. (To set the id, name or email please use setUserInfo). |
Contributor
There was a problem hiding this comment.
oops, thanks for fixing my typos 😅
sbarrio
reviewed
May 9, 2025
| canOverrideExistingModule = false, | ||
| needsEagerInit = false, | ||
| isCxxModule = false, | ||
| isTurboModule = isTurboModule |
sbarrio
reviewed
May 9, 2025
| /** | ||
| * Sets the user information. | ||
| * @param extraUserInfo: The additional information. (To set the id, name or email please user setUserInfo). | ||
| * @param extraInfo: The additional information. (To set the id, name or email please use setUserInfo). |
sbarrio
reviewed
May 9, 2025
| "react": "18.2.0", | ||
| "react-native": "0.73.9", | ||
| "react": "^19.0.0", | ||
| "react-native": "^0.79.2", |
Contributor
There was a problem hiding this comment.
Perhaps we should lock this?
sbarrio
approved these changes
May 9, 2025
Contributor
sbarrio
left a comment
sbarrio
left a comment
There was a problem hiding this comment.
Left some minor nitpicks. Awesome job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the SDK and Example Projects to use RN 0.79.
Includes refactoring and clean-up of various parts in both the SDK and example project.
The dependency on react-native-navigation has been removed from the old-architecture example project.
Review checklist (to be filled by reviewers)