Skip to content

Bump Android SDK to 2.21.0#871

Merged
sbarrio merged 1 commit into
developfrom
sbarrio/dev/bump-android-sdk-to-2.21.0
May 29, 2025
Merged

Bump Android SDK to 2.21.0#871
sbarrio merged 1 commit into
developfrom
sbarrio/dev/bump-android-sdk-to-2.21.0

Conversation

@sbarrio
Copy link
Copy Markdown
Contributor

@sbarrio sbarrio commented May 9, 2025

What does this PR do?

Bumps the dependency on dd-sdk-android to 2.21.0

Motivation

We should keep up with the latest fixes and changes introduced on the native sdks.

Notes

Screenshot 2025-05-28 at 09 55 40 Screenshot 2025-05-28 at 09 58 32

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@sbarrio sbarrio changed the base branch from marcosaia/dev/rn-79-update to develop May 13, 2025 08:41
@sbarrio sbarrio changed the base branch from develop to marcosaia/dev/rn-79-update May 13, 2025 08:41
@sbarrio sbarrio self-assigned this May 16, 2025
@sbarrio sbarrio changed the base branch from marcosaia/dev/rn-79-update to marcosaia/RUM-9842/fix-init-from-native May 19, 2025 10:46
@sbarrio sbarrio force-pushed the sbarrio/dev/bump-android-sdk-to-2.21.0 branch from dc0edfc to 4442da0 Compare May 19, 2025 11:00
@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented May 19, 2025

Datadog Report

Branch report: sbarrio/dev/bump-android-sdk-to-2.21.0
Commit report: f33bd07
Test service: dd-sdk-reactnative

✅ 0 Failed, 661 Passed, 1 Skipped, 3.48s Total Time

@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/RUM-9842/fix-init-from-native branch 2 times, most recently from cc4acdb to 1a8bebc Compare May 26, 2025 05:30
@sbarrio sbarrio force-pushed the sbarrio/dev/bump-android-sdk-to-2.21.0 branch from 4442da0 to b7990bb Compare May 26, 2025 08:30
@marco-saia-datadog marco-saia-datadog force-pushed the marcosaia/RUM-9842/fix-init-from-native branch 3 times, most recently from 725a005 to 330c1ef Compare May 27, 2025 07:06
Base automatically changed from marcosaia/RUM-9842/fix-init-from-native to develop May 27, 2025 15:36
@sbarrio sbarrio force-pushed the sbarrio/dev/bump-android-sdk-to-2.21.0 branch from b7990bb to 0d75504 Compare May 28, 2025 07:53
@sbarrio sbarrio marked this pull request as ready for review May 28, 2025 09:31
@sbarrio sbarrio requested a review from a team as a code owner May 28, 2025 09:31
Copy link
Copy Markdown
Member

@marco-saia-datadog marco-saia-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our react-native-webview package must be updated:

implementation "com.datadoghq:dd-sdk-android-webview:2.14.0"

Seems like we have missed this for previous releases as well.

@sbarrio
Copy link
Copy Markdown
Contributor Author

sbarrio commented May 28, 2025

Our react-native-webview package must be updated:

implementation "com.datadoghq:dd-sdk-android-webview:2.14.0"

Seems like we have missed this for previous releases as well.

Indeed, this is bad. I think it's time for us to automate the bump process👨‍💻

@sbarrio sbarrio force-pushed the sbarrio/dev/bump-android-sdk-to-2.21.0 branch from 09ec20a to 147e355 Compare May 28, 2025 14:11
@sbarrio sbarrio force-pushed the sbarrio/dev/bump-android-sdk-to-2.21.0 branch from 147e355 to f33bd07 Compare May 29, 2025 08:40
build_gradle_files=(
"packages/core/android/build.gradle"
"packages/react-native-session-replay/android/build.gradle"
"packages/react-native-webview/android/build.gradle"
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was missing.

Comment thread bump-native-dd-sdk.sh
@@ -0,0 +1,75 @@
#!/bin/bash
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added a bash script that will allow us to automatically update all needed files when bumping a native sdk. All we need is pass the platform and the new version to it and it will update all version numbers on the needed files.

@sbarrio sbarrio merged commit 09c7eaa into develop May 29, 2025
8 checks passed
@sbarrio sbarrio deleted the sbarrio/dev/bump-android-sdk-to-2.21.0 branch May 29, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants