[RUM-9773] Fix - Missing js_refresh_rate Metrics After Upgrading to 2.6.4#872
Merged
Merged
Conversation
sbarrio
commented
May 12, 2025
| static __weak RCTBridge *_bridge = nil; | ||
|
|
||
| - (void)setBridge:(RCTBridge *)bridge { | ||
| [super setBridge:bridge]; |
Contributor
Author
There was a problem hiding this comment.
By being explicit about this we ensure that this setter does not get removed nor lost again.
cdn34dd
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Starting from 2.6.4, the synthesized
bridgevariable onDdSdk.mmstarted being nil. This value was then provided to initialize DdSdkImplmenentation, which then caused issues down the line, one of the being that thejs_refresh_ratemetric stopped being sent as part of the view data payload.This PR introduces a settter that will be called when instantianing DdSdk.mm, ensuring that bridge is allocated and initialized by the time DdSdkImplementation is also created.
Motivation
We stop reported the js_refresh_rate metric from 2.64 through 2.7.0.
Additional Notes
This issue was inadvertently fixed as well by this PR #864. This PR builds on top of that and basically cleans up and renames a few things for clarity.
Review checklist (to be filled by reviewers)