Skip to content

[Fix] Externalize setting of minSdkVersion on sdk Android packages#873

Merged
sbarrio merged 1 commit into
developfrom
sbarrio/fix/allow-external-setting-of-minsdkversion
May 14, 2025
Merged

[Fix] Externalize setting of minSdkVersion on sdk Android packages#873
sbarrio merged 1 commit into
developfrom
sbarrio/fix/allow-external-setting-of-minsdkversion

Conversation

@sbarrio
Copy link
Copy Markdown
Contributor

@sbarrio sbarrio commented May 13, 2025

What does this PR do?

This PR modifies the SDK android packages build.gradle files so minSdkVersion is set to follow the version indicated by the root package including it instead of being forced to API level 21.

This change was proposed by @nbennink at #867. Thank you!

Motivation

The sdk should be flexible enough to adapt to its host application sdk target settings.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@sbarrio sbarrio self-assigned this May 13, 2025
@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented May 13, 2025

Datadog Summary

✅ Code Quality    ✅ Code Security    ✅ Dependencies

Test Optimization Report

Branch report: sbarrio/fix/allow-external-setting-of-minsdkversion
Commit report: d2967e4
Test service: dd-sdk-reactnative

✅ 0 Failed, 669 Passed, 1 Skipped, 3.78s Total Time


Was this helpful? Give us feedback!

@sbarrio sbarrio force-pushed the sbarrio/fix/allow-external-setting-of-minsdkversion branch from 53ba81c to d2967e4 Compare May 13, 2025 10:07
@sbarrio sbarrio marked this pull request as ready for review May 13, 2025 10:22
@sbarrio sbarrio requested a review from a team as a code owner May 13, 2025 10:22
@sbarrio sbarrio merged commit f6851f5 into develop May 14, 2025
8 checks passed
@sbarrio sbarrio deleted the sbarrio/fix/allow-external-setting-of-minsdkversion branch May 14, 2025 07:35
@sbarrio sbarrio mentioned this pull request May 14, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants