[Fix] Externalize setting of minSdkVersion on sdk Android packages#873
Merged
sbarrio merged 1 commit intoMay 14, 2025
Merged
Conversation
Datadog Summary✅ Code Quality ✅ Code Security ✅ Dependencies Test Optimization ReportBranch report: ✅ 0 Failed, 669 Passed, 1 Skipped, 3.78s Total Time Was this helpful? Give us feedback! |
53ba81c to
d2967e4
Compare
cdn34dd
approved these changes
May 13, 2025
nbennink
approved these changes
May 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR modifies the SDK android packages
build.gradlefiles sominSdkVersionis set to follow the version indicated by the root package including it instead of being forced to API level 21.This change was proposed by @nbennink at #867. Thank you!
Motivation
The sdk should be flexible enough to adapt to its host application sdk target settings.
Review checklist (to be filled by reviewers)