[RUM-9842] Refactored Session ID Event Listener and fixed initFromNative#874
Merged
marco-saia-datadog merged 13 commits intoMay 27, 2025
Merged
Conversation
marco-saia-datadog
force-pushed
the
marcosaia/RUM-9842/fix-init-from-native
branch
4 times, most recently
from
2f28023 to
3887a76
Compare
Datadog ReportBranch report: ✅ 0 Failed, 661 Passed, 1 Skipped, 3.6s Total Time |
marco-saia-datadog
force-pushed
the
marcosaia/RUM-9842/fix-init-from-native
branch
4 times, most recently
from
785e646 to
a8c2ec6
Compare
marco-saia-datadog
force-pushed
the
marcosaia/RUM-9842/fix-init-from-native
branch
from
3c5eba6 to
2ed588c
Compare
marco-saia-datadog
force-pushed
the
marcosaia/RUM-9842/fix-init-from-native
branch
from
2ed588c to
cc4acdb
Compare
![datadog-datadog-prod-us1[bot]](https://avatars.githubusercontent.com/u/365230?s=60&v=4){kind=small}
marco-saia-datadog
force-pushed
the
marcosaia/RUM-9842/fix-init-from-native
branch
from
cc4acdb to
1a8bebc
Compare
sbarrio
reviewed
May 26, 2025
sbarrio
reviewed
May 26, 2025
sbarrio
reviewed
May 26, 2025
|
|
||
| // Silence the warning https://github.com/facebook/react-native/issues/11094#issuecomment-263240420 | ||
| jest.mock('react-native/Libraries/Animated/NativeAnimatedHelper'); | ||
| // jest.mock('react-native/Libraries/Animated/NativeAnimatedHelper'); |
Contributor
There was a problem hiding this comment.
Nit: Shouldn't we just delete this line?
sbarrio
reviewed
May 26, 2025
|
|
||
| // Silence the warning https://github.com/facebook/react-native/issues/11094#issuecomment-263240420 | ||
| jest.mock('react-native/Libraries/Animated/NativeAnimatedHelper'); | ||
| // jest.mock('react-native/Libraries/Animated/NativeAnimatedHelper'); |
Contributor
There was a problem hiding this comment.
Nit: Shouldn't we just delete this line?
sbarrio
reviewed
May 26, 2025
|
|
||
| // Silence the warning https://github.com/facebook/react-native/issues/11094#issuecomment-263240420 | ||
| jest.mock('react-native/Libraries/Animated/NativeAnimatedHelper'); | ||
| // jest.mock('react-native/Libraries/Animated/NativeAnimatedHelper'); |
Contributor
There was a problem hiding this comment.
Nit: Same as above. Shouldn't we just remove this?
sbarrio
previously approved these changes
May 26, 2025
Contributor
sbarrio
left a comment
sbarrio
left a comment
There was a problem hiding this comment.
Top notch work!
(just left some minor nitpicks)
marco-saia-datadog
force-pushed
the
marcosaia/RUM-9842/fix-init-from-native
branch
from
0d33f24 to
2a4dd4f
Compare
marco-saia-datadog
force-pushed
the
marcosaia/RUM-9842/fix-init-from-native
branch
from
2a4dd4f to
725a005
Compare
marco-saia-datadog
force-pushed
the
marcosaia/RUM-9842/fix-init-from-native
branch
from
725a005 to
330c1ef
Compare
sbarrio
approved these changes
May 27, 2025
This was referenced May 28, 2025
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Refactors the Session ID listener logic to use
BatchedBridgein old-architecture, and TurboModule Event Emitter in new-architecture to retrieve the RUM Session ID from the native layer;Updates the RN SDK and example project to use RN 0.76.9, to grant compatibility with Xcode 16.3
Updates Gitlab CI script for compatibility with RN 0.76.9 update
Review checklist (to be filled by reviewers)