Skip to content

[RUM-9768] Fix deadlock on RCTTextViewRecorder when retrieving a shadow view#883

Merged
cdn34dd merged 1 commit into
developfrom
carlosnogueira/RUM-9768/fix-datepicker-hang
May 22, 2025
Merged

[RUM-9768] Fix deadlock on RCTTextViewRecorder when retrieving a shadow view#883
cdn34dd merged 1 commit into
developfrom
carlosnogueira/RUM-9768/fix-datepicker-hang

Conversation

@cdn34dd
Copy link
Copy Markdown
Contributor

@cdn34dd cdn34dd commented May 21, 2025

What does this PR do?

FIxes app hang caused by deadlock on RCTTextViewRecorder custom node recorder.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@cdn34dd cdn34dd requested a review from a team as a code owner May 21, 2025 16:00
@cdn34dd cdn34dd changed the title RUM-9768: fix deadlock on RCTTextViewRecorder when retrieving a shadow view [RUM-9768] Fix deadlock on RCTTextViewRecorder when retrieving a shadow view May 22, 2025
sbarrio
sbarrio previously approved these changes May 22, 2025
Copy link
Copy Markdown
Contributor

@sbarrio sbarrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top notch work 👏

@cdn34dd cdn34dd force-pushed the carlosnogueira/RUM-9768/fix-datepicker-hang branch from 7fa3baf to 833b4b4 Compare May 22, 2025 13:18
@cdn34dd cdn34dd merged commit 1d8aaa7 into develop May 22, 2025
2 of 8 checks passed
@cdn34dd cdn34dd deleted the carlosnogueira/RUM-9768/fix-datepicker-hang branch May 22, 2025 13:20
@cdn34dd cdn34dd mentioned this pull request May 22, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants