Skip to content

[RUM-10113] Fix static linkage configuration problem#886

Merged
cdn34dd merged 1 commit into
developfrom
carlosnogueira/RUM-10113/fix-static-linkage-build-error
May 28, 2025
Merged

[RUM-10113] Fix static linkage configuration problem#886
cdn34dd merged 1 commit into
developfrom
carlosnogueira/RUM-10113/fix-static-linkage-build-error

Conversation

@cdn34dd
Copy link
Copy Markdown
Contributor

@cdn34dd cdn34dd commented May 26, 2025

What does this PR do?

Fixes bug that prevents apps from building when including either react-native-session-replay or react-native-webview packages with static linkage enabled.

Motivation

While we already have a workaround for the issue, we wanted to have something that works out of the box.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@cdn34dd cdn34dd requested a review from a team as a code owner May 26, 2025 14:28
@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented May 26, 2025

Datadog Report

Branch report: carlosnogueira/RUM-10113/fix-static-linkage-build-error
Commit report: 9a2ea55
Test service: dd-sdk-reactnative

✅ 0 Failed, 661 Passed, 1 Skipped, 3.45s Total Time

@marco-saia-datadog
Copy link
Copy Markdown
Member

@cdn34dd Great work 🙌 Does this require any additional setup from the user side?

Copy link
Copy Markdown
Contributor

@sbarrio sbarrio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏

- Affected `react-native-session-replay` & `react-native-webview`
- Now relies on `USE_FRAMEWORKS` env variable in order to support static
linkage
@cdn34dd cdn34dd force-pushed the carlosnogueira/RUM-10113/fix-static-linkage-build-error branch from 2ee5280 to 9a2ea55 Compare May 28, 2025 13:46
@cdn34dd cdn34dd merged commit 64e6c2c into develop May 28, 2025
8 checks passed
@cdn34dd cdn34dd deleted the carlosnogueira/RUM-10113/fix-static-linkage-build-error branch May 28, 2025 14:09
@sbarrio sbarrio mentioned this pull request Jun 2, 2025
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants