[RUM-9982] Set up React Native babel plugin project#887
Merged
Conversation
d349fce to
ec57bde
Compare
Datadog ReportBranch report: ✅ 0 Failed, 661 Passed, 1 Skipped, 8.16s Total Time |
marco-saia-datadog
approved these changes
May 28, 2025
Member
marco-saia-datadog
left a comment
There was a problem hiding this comment.
Great work! 🙌 I am approving this because I believe the points I have raised in my comments are non-blockers at this stage
marco-saia-datadog
requested changes
May 28, 2025
Member
marco-saia-datadog
left a comment
There was a problem hiding this comment.
Actually, we do have a blocker, as checks are failing.
I believe the problem is the missing tsconfig.json in the react-native-babel-plugin folder:
> @datadog/mobile-react-native-babel-plugin:prepare
ℹ Building target commonjs
ℹ Cleaning up previous build at lib/commonjs
ℹ Compiling 9 files in src with babel
✔ Wrote files to lib/commonjs
ℹ Building target module
ℹ Cleaning up previous build at lib/module
ℹ Compiling 9 files in src with babel
✔ Wrote files to lib/module
ℹ Building target typescript
ℹ Cleaning up previous build at lib/typescript
ℹ Generating type definitions with tsc
✖ Couldn't find a tsconfig.json in the project root.
sbarrio
reviewed
May 28, 2025
ec57bde to
dc78cdd
Compare
- Adds global signaling plugin has been enabled on the users' codebase - Setup base architecture for plugin
dc78cdd to
4a79ad0
Compare
marco-saia-datadog
approved these changes
May 28, 2025
4a79ad0
into
carlosnogueira/RUM-9145/refactor-rum-action-tracking
6 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Sets up new project consisting of a babel plugin, aiming to make React Native's sdks work more seamlessly.
In it's current state, it has the basic file structure in place and it's already integrated into the workspace. It also sets up a flag when integrated on a React Native app, that will later on be used to add Telemetry and to allow the code to choose whether to rely on the babel plugin for RUM actions or to rely on the current approach.
Review checklist (to be filled by reviewers)