Skip to content

[RUM-9982] Set up React Native babel plugin project#887

Merged
cdn34dd merged 1 commit into
carlosnogueira/RUM-9145/refactor-rum-action-trackingfrom
carlosnogueira/RUM-9982/setup-base-package-for-babel-plugin
May 28, 2025
Merged

[RUM-9982] Set up React Native babel plugin project#887
cdn34dd merged 1 commit into
carlosnogueira/RUM-9145/refactor-rum-action-trackingfrom
carlosnogueira/RUM-9982/setup-base-package-for-babel-plugin

Conversation

@cdn34dd
Copy link
Copy Markdown
Contributor

@cdn34dd cdn34dd commented May 27, 2025

What does this PR do?

Sets up new project consisting of a babel plugin, aiming to make React Native's sdks work more seamlessly.

In it's current state, it has the basic file structure in place and it's already integrated into the workspace. It also sets up a flag when integrated on a React Native app, that will later on be used to add Telemetry and to allow the code to choose whether to rely on the babel plugin for RUM actions or to rely on the current approach.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests
  • Make sure you discussed the feature or bugfix with the maintaining team in an Issue
  • Make sure each commit and the PR mention the Issue number (cf the CONTRIBUTING doc)
  • If this PR is auto-generated, please make sure also to manually update the code related to the change

@cdn34dd cdn34dd requested a review from a team as a code owner May 27, 2025 15:35
Comment thread packages/react-native-babel-plugin/src/utils/index.ts Outdated
Comment thread packages/react-native-babel-plugin/src/index.ts
Comment thread packages/react-native-babel-plugin/src/types/helper-plugin-utils.ts
Comment thread packages/react-native-babel-plugin/src/actions/global/index.ts Outdated
Comment thread packages/react-native-babel-plugin/src/actions/global/index.ts Outdated
@cdn34dd cdn34dd force-pushed the carlosnogueira/RUM-9982/setup-base-package-for-babel-plugin branch from d349fce to ec57bde Compare May 27, 2025 15:41
@cdn34dd cdn34dd changed the base branch from develop to carlosnogueira/RUM-9145/refactor-rum-action-tracking May 27, 2025 15:42
@datadog-datadog-prod-us1
Copy link
Copy Markdown

datadog-datadog-prod-us1 Bot commented May 27, 2025

Datadog Report

Branch report: carlosnogueira/RUM-9982/setup-base-package-for-babel-plugin
Commit report: 4a79ad0
Test service: dd-sdk-reactnative

✅ 0 Failed, 661 Passed, 1 Skipped, 8.16s Total Time

Copy link
Copy Markdown
Member

@marco-saia-datadog marco-saia-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! 🙌 I am approving this because I believe the points I have raised in my comments are non-blockers at this stage

Comment thread packages/react-native-babel-plugin/src/types/general.ts Outdated
Comment thread packages/react-native-babel-plugin/src/actions/global/index.ts Outdated
Comment thread packages/react-native-babel-plugin/src/utils/index.ts Outdated
Copy link
Copy Markdown
Member

@marco-saia-datadog marco-saia-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, we do have a blocker, as checks are failing.

I believe the problem is the missing tsconfig.json in the react-native-babel-plugin folder:

> @datadog/mobile-react-native-babel-plugin:prepare
ℹ Building target commonjs
ℹ Cleaning up previous build at lib/commonjs
ℹ Compiling 9 files in src with babel
✔ Wrote files to lib/commonjs
ℹ Building target module
ℹ Cleaning up previous build at lib/module
ℹ Compiling 9 files in src with babel
✔ Wrote files to lib/module
ℹ Building target typescript
ℹ Cleaning up previous build at lib/typescript
ℹ Generating type definitions with tsc
✖ Couldn't find a tsconfig.json in the project root.

Comment thread NATIVE_SDK_VERSIONS.md
@cdn34dd cdn34dd force-pushed the carlosnogueira/RUM-9982/setup-base-package-for-babel-plugin branch from ec57bde to dc78cdd Compare May 28, 2025 10:22
- Adds global signaling plugin has been enabled on the users' codebase
- Setup base architecture for plugin
@cdn34dd cdn34dd force-pushed the carlosnogueira/RUM-9982/setup-base-package-for-babel-plugin branch from dc78cdd to 4a79ad0 Compare May 28, 2025 10:34
@cdn34dd cdn34dd merged commit 4a79ad0 into carlosnogueira/RUM-9145/refactor-rum-action-tracking May 28, 2025
6 checks passed
@cdn34dd cdn34dd deleted the carlosnogueira/RUM-9982/setup-base-package-for-babel-plugin branch May 28, 2025 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants