Conversation
e87d4d0 to
dd15ce5
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dd15ce544c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dd15ce5 to
d52f906
Compare
d52f906 to
f4ec131
Compare
|
LGTM, let's test with this next week before merging it |
2184fd7 to
a9acadb
Compare
a9acadb to
c1f77de
Compare
| - [ ] GitHub release created (with zip asset) | ||
| - [ ] npm publish verified | ||
| - [ ] Release branch merged to main (via PR) | ||
| - [ ] Release branch merged to develop (via PR) |
There was a problem hiding this comment.
Can you add a step to verify that the release is available on npm?
for example, we should be able to open https://www.npmjs.com/package/datadog-roku/v/1.4.0 when 1.4.0 is published.
There was a problem hiding this comment.
Added in step 7 and npm publish verified (npm view and npmjs.com page) line on summary checklist.
8830f3e to
0978390
Compare
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
0978390 to
9335397
Compare
release.shscript.createdtopublishedinpublish.yamlfile so we can retrigger thepublishjob easily (if the version is actually already published on npm, it won't override it and nothing happens).