Skip to content

Refactor into a single crate#357

Merged
fuchsnj merged 5 commits into
mainfrom
fuchsnj/crate_refactor
May 21, 2026
Merged

Refactor into a single crate#357
fuchsnj merged 5 commits into
mainfrom
fuchsnj/crate_refactor

Conversation

@fuchsnj
Copy link
Copy Markdown
Contributor

@fuchsnj fuchsnj commented May 13, 2026

This refactors the repo into a single Rust crate so make publishing to crates.io easier. Each crate is now part of the single dd-sensitive-data-scanner crate but behind separate feature flags so you can still pull in only the parts you want.

This is just changing the code organization around, there is no new features, except the new CI job for publishing the crate.

@fuchsnj fuchsnj marked this pull request as ready for review May 20, 2026 19:20
@fuchsnj fuchsnj requested a review from a team as a code owner May 20, 2026 19:20
Copy link
Copy Markdown
Contributor

@isabella-garza-datadog isabella-garza-datadog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall!

One question I had while reviewing this was how it impacts integrations that build dd-sds directly. I took a look at agentless, and it seems like they build the sds-go crate directly (link). If I’m understanding correctly, this would be a breaking change for that setup and would require updating how SDS is built in that repo, right? It’s probably worth creating a ticket for the Data Security pod to track that follow-up.

Also curious if you know of any other integrations that might be impacted by this change.

@fuchsnj
Copy link
Copy Markdown
Contributor Author

fuchsnj commented May 21, 2026

One question I had while reviewing this was how it impacts integrations that build dd-sds directly. I took a look at agentless

That is using the sds-go Go bindings, which should not be impacted by this change. Only the Rust crates were merged, but the go bindings should be the same.

@fuchsnj fuchsnj merged commit 6cedb91 into main May 21, 2026
4 checks passed
@fuchsnj fuchsnj deleted the fuchsnj/crate_refactor branch May 21, 2026 20:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants