[feature] [SQS] Inject trace data to message metadata#1807
Merged
Conversation
Czechh
changed the title
Co-authored-by: Kyle Verhoog <kyle@verhoog.ca>
Codecov Report
@@ Coverage Diff @@
## master #1807 +/- ##
==========================================
- Coverage 80.36% 74.75% -5.61%
==========================================
Files 546 546
Lines 37206 37376 +170
==========================================
- Hits 29899 27942 -1957
- Misses 7307 9434 +2127
Continue to review full report at Codecov.
|
Member
Kyle-Verhoog
left a comment
Kyle-Verhoog
left a comment
There was a problem hiding this comment.
👍 for the tests, just one comment and I think we're good to go.
…github.com:DataDog/dd-trace-py into sergio.prada/inject-trace-data-to-message-meta-sqs * 'sergio.prada/inject-trace-data-to-message-meta-sqs' of github.com:DataDog/dd-trace-py: refactor(profiling): deprecate pyddprofile (#1816) chore(profiling): remove deprecated ddtrace.profile (#1817) ci: add coverage job (#1764)
Czechh
deleted the
sergio.prada/inject-trace-data-to-message-meta-sqs
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We inject trace data into the
MessageAttributesmetadata. This is already done indd-trace-jshttps://github.com/DataDog/dd-trace-js/blob/master/packages/datadog-plugin-aws-sdk/src/services/sqs.js#L39-L59This will allow clients to extract the trace data and build better distributed tracing.
Checklist