Merged
Conversation
3158e77 to
b617b54
Compare
7 tasks
majorgreys
reviewed
Dec 8, 2020
Kyle-Verhoog
commented
Jan 22, 2021
Codecov Report
@@ Coverage Diff @@
## master #1808 +/- ##
==========================================
+ Coverage 90.90% 90.94% +0.04%
==========================================
Files 555 559 +4
Lines 38819 39063 +244
==========================================
+ Hits 35287 35527 +240
- Misses 3532 3536 +4
Continue to review full report at Codecov.
|
Kyle-Verhoog
commented
Jan 25, 2021
…t/response header tracing. Handled builtins.GeneratorExit errors with streaming requests.
Kyle-Verhoog
commented
Jan 26, 2021
Kyle-Verhoog
commented
Jan 27, 2021
Yun-Kim
previously approved these changes
Jan 27, 2021
Kyle-Verhoog
commented
Jan 27, 2021
…hot test for chunked response.
Yun-Kim
approved these changes
Jan 27, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integration
This PR adds a WSGI middleware to be used to trace any WSGI Python web application.
Note: in cases of interrupted streaming requests, which can lead to broken pipe connections and therefore
GeneratorExitexceptions in the response spans, the decision was made to prevent theGeneratorExitexceptions from being propagated to the top-level request spans. These exceptions will still be present in thewsgi.responsespans.Links
Checklist
__init__.py.DD_SERVICE(if applicable).ddtrace.config.Pin overriding..circleci/config.yml).builtins.GeneratorExiterrors with streaming requests (expected behaviour?) probably have to use span ignored exceptions.