Skip to content

V0.45.0 async#1941

Closed
remigabillet wants to merge 7 commits intoDataDog:masterfrom
envoy:v0.45.0_async
Closed

V0.45.0 async#1941
remigabillet wants to merge 7 commits intoDataDog:masterfrom
envoy:v0.45.0_async

Conversation

@remigabillet
Copy link

No description provided.

@remigabillet remigabillet requested a review from a team as a code owner January 15, 2021 22:01
@Kyle-Verhoog
Copy link
Member

@remigabillet thanks for the contribution! Can you provide a bit more context? It seems like ddtrace already handles async django requests so I'm curious of when get_response_async is used instead of get_response.

It'd also be great to have tests to verify that it works 🙂

@mergify
Copy link
Contributor

mergify bot commented May 19, 2021

@remigabillet this pull request is now in conflict 😩

@mergify mergify bot added the conflict label May 19, 2021
@Kyle-Verhoog
Copy link
Member

This will be addressed by #2656

@remigabillet
Copy link
Author

@Kyle-Verhoog it's so strange I don't remember ever opening this PR. I don't think I meant to. I just forked for internal use.
Anyway, thanks for addressing the issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants