updates banner for korean dash announcement#35308
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dfedd8f9e7
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| desktop_message: "<span>Join Datadog at DASH—coming to NYC June 9-10. Register now for Super Early Bird savings of $700 until March 31</span>" | ||
| mobile_message: "<span>Join us at DASH—June 9-10. Save $700 until March 31</span>" | ||
| desktop_message: "<span>6월 9일~10일에 진행되는 DASH에 참여하세요. 3월 31일까지 등록하면 $700를 절약할 수 있습니다.</span>" | ||
| external_link: "https://dash.datadoghq.com/?utm_source=events&utm_medium=internal&utm_campaign=summit-202606dash&utm_term=HPbanner" |
There was a problem hiding this comment.
Use raw & separators in external_link instead of &. The Korean banner URL is now HTML-escaped in config, and when Hugo templates escape attributes at render time this becomes double-escaped (&amp;), so the outgoing link carries parameters like amp;utm_medium/amp;utm_campaign rather than the intended UTM keys; this breaks campaign attribution for KO banner clicks (other locale params files keep the URL unescaped).
Useful? React with 👍 / 👎.
1 participant
What does this PR do? What is the motivation?
Merge instructions
Merge readiness:
For Datadog employees:
Your branch name MUST follow the
<name>/<description>convention and include the forward slash (/). Without this format, your pull request will not pass CI, the GitLab pipeline will not run, and you won't get a branch preview. Getting a branch preview makes it easier for us to check any issues with your PR, such as broken links.If your branch doesn't follow this format, rename it or create a new branch and PR.
[6/5/2025] Merge queue has been disabled on the documentation repo. If you have write access to the repo, the PR has been reviewed by a Documentation team member, and all of the required checks have passed, you can use the Squash and Merge button to merge the PR. If you don't have write access, or you need help, reach out in the #documentation channel in Slack.
AI assistance
Additional notes