tests(telemetry): flush metrics with heartbeats if the interval is small #1418
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Motivation Tests usually set the telemetry hearbeat interval to a small value to not have to wait to get data. For these tests also want to get telemetry metrics fast. This PR changes the metics flush interval to the heartbeat value if the hearbeat interval is set to a shorter duration than the default metrics flush interval.
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1418 +/- ##
==========================================
+ Coverage 71.22% 71.44% +0.21%
==========================================
Files 404 411 +7
Lines 64477 66046 +1569
==========================================
+ Hits 45923 47185 +1262
- Misses 18554 18861 +307
🚀 New features to boost your workflow:
|
BenchmarksComparisonBenchmark execution time: 2025-12-26 16:16:52 Comparing candidate commit ef9d964 in PR branch Found 1 performance improvements and 14 performance regressions! Performance is the same for 42 metrics, 2 unstable metrics. scenario:credit_card/is_card_number/ 3782-8224-6310-005
scenario:credit_card/is_card_number/378282246310005
scenario:credit_card/is_card_number/37828224631000521389798
scenario:credit_card/is_card_number_no_luhn/ 3782-8224-6310-005
scenario:credit_card/is_card_number_no_luhn/ 378282246310005
scenario:credit_card/is_card_number_no_luhn/378282246310005
scenario:credit_card/is_card_number_no_luhn/37828224631000521389798
scenario:sql/obfuscate_sql_string
CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
ekump
approved these changes
Dec 18, 2025
Contributor
ekump
left a comment
ekump
left a comment
There was a problem hiding this comment.
Is this something we can easily unit test? Otherwise LGTM.
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-apple-darwin
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-apple-darwin
x86_64-unknown-linux-gnu
|
iunanua
reviewed
Dec 19, 2025
| .field("cancellation_token", &self.cancellation_token) | ||
| .field("seq_id", &self.seq_id) | ||
| .field("runtime_id", &self.runtime_id) | ||
| .field("deadlines", &self.deadlines) |
Contributor
There was a problem hiding this comment.
Suggested change
| .field("metrics_flush_interval", &self.metrics_flush_interval) | |
| .field("deadlines", &self.deadlines) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Tests usually set the telemetry hearbeat interval to a small value to not have to wait to get data. For these tests also want to get telemetry metrics fast. This PR changes the metics flush interval to the heartbeat value if the hearbeat interval is set to a shorter duration than the default metrics flush interval.