-
Notifications
You must be signed in to change notification settings - Fork 15
Remove lz4_flex from libdd-profiling
#1427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
lz4_flex from libdd-profiling
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1427 +/- ##
==========================================
- Coverage 71.44% 71.42% -0.03%
==========================================
Files 411 411
Lines 66044 66044
==========================================
- Hits 47186 47172 -14
- Misses 18858 18872 +14
🚀 New features to boost your workflow:
|
BenchmarksComparisonBenchmark execution time: 2026-01-03 01:41:43 Comparing candidate commit 6d390ee in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 57 metrics, 2 unstable metrics. CandidateCandidate benchmark detailsGroup 1
Group 2
Group 3
Group 4
Group 5
Group 6
Group 7
Group 8
Group 9
Group 10
Group 11
Group 12
Group 13
Group 14
Group 15
Group 16
Group 17
Group 18
Group 19
BaselineOmitted due to size. |
Artifact Size Benchmark Reportaarch64-alpine-linux-musl
aarch64-apple-darwin
aarch64-unknown-linux-gnu
libdatadog-x64-windows
libdatadog-x86-windows
x86_64-alpine-linux-musl
x86_64-apple-darwin
x86_64-unknown-linux-gnu
|
What does this PR do?
Remove the
lz4_flexcrate from the dependencies and update test to use uncompressed fileMotivation
We removed lz4 in favour of zstd, but I saw an lz4 crate being compiled every time I build
dd-trace-phpand we should not compile stuff we don't need anymore.Additional Notes
Anything else we should know when reviewing?
How to test the change?
cargo test