Skip to content

libddwaf v2#377

Merged
Anilm3 merged 73 commits into
masterfrom
anilm3/v2
Oct 1, 2025
Merged

libddwaf v2#377
Anilm3 merged 73 commits into
masterfrom
anilm3/v2

Conversation

@Anilm3
Copy link
Copy Markdown
Collaborator

@Anilm3 Anilm3 commented Mar 4, 2025

This PR tracks the current progress for the v2-alpha release, all changes will be independently reviewed before merging them to this branch.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Mar 4, 2025

Codecov Report

❌ Patch coverage is 81.65260% with 413 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.87%. Comparing base (bea83f9) to head (924b09f).
⚠️ Report is 24 commits behind head on master.

Files with missing lines Patch % Lines
src/interface.cpp 53.51% 98 Missing and 54 partials ⚠️
src/object.hpp 83.53% 1 Missing and 82 partials ⚠️
src/processor/base.hpp 55.55% 7 Missing and 9 partials ⚠️
src/ruleset_info.hpp 36.36% 0 Missing and 14 partials ⚠️
src/configuration/common/raw_configuration.cpp 89.60% 3 Missing and 10 partials ⚠️
src/evaluation_engine.hpp 71.42% 4 Missing and 8 partials ⚠️
src/iterator.cpp 93.33% 0 Missing and 8 partials ⚠️
src/log.hpp 50.00% 7 Missing and 1 partial ⚠️
src/dynamic_string.hpp 89.70% 0 Missing and 7 partials ⚠️
src/utils.hpp 79.41% 6 Missing and 1 partial ⚠️
... and 36 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #377      +/-   ##
==========================================
- Coverage   85.23%   84.87%   -0.36%     
==========================================
  Files         186      190       +4     
  Lines        9387     9814     +427     
  Branches     4170     4284     +114     
==========================================
+ Hits         8001     8330     +329     
- Misses        552      613      +61     
- Partials      834      871      +37     
Flag Coverage Δ
waf_test 84.87% <81.65%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 15, 2025

Benchmarks clang

Benchmark execution time: 2025-10-01 10:30:45

Comparing candidate commit 924b09f in PR branch anilm3/v2 with baseline commit bea83f9 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 0 metrics, 0 unstable metrics.

scenario:global-benchmark.random.clang

  • 🟩 execution_time [-9.191ms; -9.178ms] or [-3.219%; -3.214%]

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 15, 2025

Benchmarks gcc

Benchmark execution time: 2025-10-01 10:30:23

Comparing candidate commit 924b09f in PR branch anilm3/v2 with baseline commit bea83f9 in branch master.

Found 1 performance improvements and 0 performance regressions! Performance is the same for 0 metrics, 0 unstable metrics.

scenario:global-benchmark.random.gcc

  • 🟩 execution_time [-14.217ms; -14.206ms] or [-5.187%; -5.182%]

@Anilm3 Anilm3 marked this pull request as ready for review March 16, 2025 16:54
@Anilm3 Anilm3 requested a review from a team as a code owner March 16, 2025 16:54
@DataDog DataDog deleted a comment from pr-commenter Bot Mar 16, 2025
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented Mar 19, 2025

Benchmarks clang-pgo

Benchmark execution time: 2025-09-30 17:23:00

Comparing candidate commit dfab598 in PR branch anilm3/v2 with baseline commit 82d66cd in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 1 metrics, 0 unstable metrics.

@Anilm3 Anilm3 requested a review from Copilot March 28, 2025 07:22
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR tracks progress for the v2-alpha release of libddwaf by streamlining the workflow configuration. Key changes include the complete removal of the "docker-builds" job and the corresponding update to the "release" job dependencies.

Files not reviewed (19)
  • benchmark/main.cpp: Language not supported
  • cmake/objects.cmake: Language not supported
  • fuzzer/cmdi_detector/src/main.cpp: Language not supported
  • fuzzer/global/src/interface.cpp: Language not supported
  • fuzzer/http_endpoint_fingerprint/src/main.cpp: Language not supported
  • fuzzer/http_header_fingerprint/src/main.cpp: Language not supported
  • fuzzer/http_network_fingerprint/src/main.cpp: Language not supported
  • fuzzer/lfi_detector/src/main.cpp: Language not supported
  • fuzzer/session_fingerprint/src/main.cpp: Language not supported
  • fuzzer/shi_detector_array/src/main.cpp: Language not supported
  • fuzzer/shi_detector_string/src/main.cpp: Language not supported
  • fuzzer/sqli_detector/src/main.cpp: Language not supported
  • fuzzer/ssrf_detector/src/main.cpp: Language not supported
  • include/ddwaf.h: Language not supported
  • src/argument_retriever.hpp: Language not supported
  • src/builder/ruleset_builder.cpp: Language not supported
  • src/builder/ruleset_builder.hpp: Language not supported
  • src/builder/waf_builder.hpp: Language not supported
  • src/condition/base.hpp: Language not supported
Comments suppressed due to low confidence (2)

.github/workflows/build.yml:166

  • The removal of the 'docker-builds' job may affect the release process if any expected artifacts were generated by it. Please ensure that any required docker build artifacts are either no longer needed or are produced by alternative steps.
    -  docker-builds:

.github/workflows/build.yml:292

  • Updating the release job dependencies by removing 'docker-builds' should be verified to ensure that no necessary build steps or artifacts are omitted in the overall release pipeline.
    needs: [ windows-builds, macos-build, linux-musl-build, package-nuget]

@Anilm3
Copy link
Copy Markdown
Collaborator Author

Anilm3 commented Sep 19, 2025

@codex review

@chatgpt-codex-connector
Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Nice work!

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Copy link
Copy Markdown
Contributor

@cataphract cataphract left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pro forma approval

@Anilm3
Copy link
Copy Markdown
Collaborator Author

Anilm3 commented Sep 30, 2025

Commits without signature have been verified manually, an interactive rebase is simply not feasible.

@Anilm3 Anilm3 merged commit 482b5df into master Oct 1, 2025
55 of 56 checks passed
@Anilm3 Anilm3 deleted the anilm3/v2 branch October 28, 2025 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants