Conversation
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## master #377 +/- ##
==========================================
- Coverage 85.23% 84.87% -0.36%
==========================================
Files 186 190 +4
Lines 9387 9814 +427
Branches 4170 4284 +114
==========================================
+ Hits 8001 8330 +329
- Misses 552 613 +61
- Partials 834 871 +37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Benchmarks clangBenchmark execution time: 2025-10-01 10:30:45 Comparing candidate commit 924b09f in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 0 metrics, 0 unstable metrics. scenario:global-benchmark.random.clang
|
Benchmarks gccBenchmark execution time: 2025-10-01 10:30:23 Comparing candidate commit 924b09f in PR branch Found 1 performance improvements and 0 performance regressions! Performance is the same for 0 metrics, 0 unstable metrics. scenario:global-benchmark.random.gcc
|
There was a problem hiding this comment.
Pull Request Overview
This PR tracks progress for the v2-alpha release of libddwaf by streamlining the workflow configuration. Key changes include the complete removal of the "docker-builds" job and the corresponding update to the "release" job dependencies.
Files not reviewed (19)
- benchmark/main.cpp: Language not supported
- cmake/objects.cmake: Language not supported
- fuzzer/cmdi_detector/src/main.cpp: Language not supported
- fuzzer/global/src/interface.cpp: Language not supported
- fuzzer/http_endpoint_fingerprint/src/main.cpp: Language not supported
- fuzzer/http_header_fingerprint/src/main.cpp: Language not supported
- fuzzer/http_network_fingerprint/src/main.cpp: Language not supported
- fuzzer/lfi_detector/src/main.cpp: Language not supported
- fuzzer/session_fingerprint/src/main.cpp: Language not supported
- fuzzer/shi_detector_array/src/main.cpp: Language not supported
- fuzzer/shi_detector_string/src/main.cpp: Language not supported
- fuzzer/sqli_detector/src/main.cpp: Language not supported
- fuzzer/ssrf_detector/src/main.cpp: Language not supported
- include/ddwaf.h: Language not supported
- src/argument_retriever.hpp: Language not supported
- src/builder/ruleset_builder.cpp: Language not supported
- src/builder/ruleset_builder.hpp: Language not supported
- src/builder/waf_builder.hpp: Language not supported
- src/condition/base.hpp: Language not supported
Comments suppressed due to low confidence (2)
.github/workflows/build.yml:166
- The removal of the 'docker-builds' job may affect the release process if any expected artifacts were generated by it. Please ensure that any required docker build artifacts are either no longer needed or are produced by alternative steps.
- docker-builds:
.github/workflows/build.yml:292
- Updating the release job dependencies by removing 'docker-builds' should be verified to ensure that no necessary build steps or artifacts are omitted in the overall release pipeline.
needs: [ windows-builds, macos-build, linux-musl-build, package-nuget]
…etime derived from the context (#443)
|
@codex review |
|
Codex Review: Didn't find any major issues. Nice work! About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback". |
|
Commits without signature have been verified manually, an interactive rebase is simply not feasible. |
This PR tracks the current progress for the v2-alpha release, all changes will be independently reviewed before merging them to this branch.