Well data relationships should enforce parent-child integrity

[kbighorse]

Summary

Enforces parent-child integrity for NMA legacy tables and refactors them from UUID to Integer primary keys for consistency with the rest of the schema.

Fixes #363

Changes

1. Integer PK Refactoring

• Added id (Integer, autoincrement) as primary key to 8 NMA tables
• Renamed existing UUID columns with nma_ prefix for audit/traceability
• Standardized FK naming to chemistry_sample_info_id (Integer) pattern

2. Tables Modified

Table	New PK	Legacy UUID Column
NMA_Chemistry_SampleInfo	id	nma_sample_pt_id
NMA_FieldParameters	id	nma_global_id
NMA_MajorChemistry	id	nma_global_id
NMA_MinorTraceChemistry	id	nma_global_id
NMA_Radionuclides	id	nma_global_id
NMA_HydraulicsData	id	nma_global_id
NMA_Stratigraphy	id	nma_global_id
NMA_AssociatedData	id	nma_assoc_id

3. FK Enforcement

• All NMA child tables require a parent Thing (thing_id NOT NULL)
• Chemistry child tables require parent sample info (chemistry_sample_info_id NOT NULL)
• Cascade deletes enabled: deleting a Thing removes all related NMA records

4. Code Updates

• Models (db/nma_legacy.py): Updated column definitions and relationships
• Transfers (transfers/*.py): Updated column mappings for new schema
• Admin views (admin/views/*.py): Updated pk_attr and pk_type
• Tests: Updated for Integer PKs and correct DB column name access

Orphan Records Discovered

The FK enforcement successfully prevented orphan records from being transferred. The following records exist in the legacy SQL Server database but have no valid parent record:

Table	Valid Records	Orphan Records Prevented
HydraulicsData	0	288
ChemistrySampleInfo	1,622	9,820
MajorChemistry	16,532	62,046
Radionuclides	12	351
MinorTraceChemistry	31,721	76,640
FieldParameters	2,899	11,035

Total orphan records prevented: ~160,180

Example Orphan Subtree

┌─────────────────────────────────────────────────────────────────────┐
│ LEVEL 0: Thing (MISSING - causes orphan cascade)                    │
├─────────────────────────────────────────────────────────────────────┤
│ Expected name: ar-1001                                              │
│ Status: NOT FOUND in WellData.csv                                   │
│ Reason: Well was never registered in the source database           │
└─────────────────────────────────────────────────────────────────────┘
          │
          │ (FK: thing_id → Thing.id)
          ▼
┌─────────────────────────────────────────────────────────────────────┐
│ LEVEL 1: ChemistrySampleInfo (ORPHAN)                               │
├─────────────────────────────────────────────────────────────────────┤
│ SamplePointID: AR-1001B                                             │
│ SamplePtID: FA79D688-8BCB-B64F-8E2D-409324D0DD8C                    │
│ CollectionDate: 2018-10-02                                          │
│                                                                     │
│ Status: FILTERED OUT - No parent Thing exists                       │
└─────────────────────────────────────────────────────────────────────┘
          │
          │ (FK: chemistry_sample_info_id → ChemistrySampleInfo.id)
          ▼
┌─────────────────────────────────────────────────────────────────────┐
│ LEVEL 2: MinorTraceChemistry (62 ORPHAN records)                    │
├─────────────────────────────────────────────────────────────────────┤
│   • Ba(total) = 0.001                                               │
│   • Ti(total) = 0.001                                               │
│   • Pb = 0.0005                                                     │
│   ... and 59 more records                                           │
│                                                                     │
│ Status: ALL FILTERED OUT - Parent ChemistrySampleInfo is orphan     │
└─────────────────────────────────────────────────────────────────────┘

Root cause: No Well record exists in the source database for PointID "AR-1001"
Impact: 1 ChemistrySampleInfo + 62 chemistry results = 63 orphan records prevented

The high number of chemistry orphans cascades from ChemistrySampleInfo - when sample info records are filtered out for lacking a parent Thing, their child chemistry records become orphans too.

Test Plan

• All 436 tests passing
• Transfer scripts run successfully against dev database
• Cascade deletes verified in integration tests
• Orphan records correctly filtered during transfer

🤖 Generated with Claude Code

[Copilot]

Pull request overview

This PR adds a comprehensive feature specification that defines business requirements for well data relationships in the NMBGMR system, ensuring parent-child integrity between wells and their associated data records.

Changes:

• Defines requirements for wells to store legacy identifiers (WellID and LocationID) from NM_Aquifer
• Specifies that all well-related records (chemistry, hydraulics, stratigraphy, radionuclides, associated data, soil/rock) must have a parent well
• Establishes cascade delete behavior to prevent orphaned records when wells are deleted

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[Copilot]

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 2 comments.

[Copilot]

Pull request overview

Copilot reviewed 13 out of 13 changed files in this pull request and generated 11 comments.

[Copilot]

Pull request overview

Copilot reviewed 14 out of 14 changed files in this pull request and generated no new comments.

[Copilot]

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

[kbighorse]

@chasetmartin the one major change is replacing UUID primary keys with integers. We could keep the UUIDs if there's good reason to, but this fits the need IMO.