(City,Zip) pair Match #29
Open
zmousavi wants to merge 2 commits into
Open
Conversation
kathyxiong
suggested changes
Sep 2, 2020
kathyxiong
left a comment
kathyxiong
left a comment
There was a problem hiding this comment.
On line 165 I am getting this warning message:
Warning message: In adbs$ImputedState[(adbs$ImputedState == "XX" & !is.na(adbs$Zip))] = imputed_states : number of items to replace is not a multiple of replacement length
adbs$ImputedState[(adbs$ImputedState == "XX" & !is.na(adbs$Zip))] has a length of 44 and imputed_states has a length of 25.
Rest of the code looks good, but we might want to look into this^ issue before merging.
|
@zmousavi any update on this PR? I'd love to incorporate this into the main functionality if possible. |
Author
|
@kathyxiong I don't see the warning on my end. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checked whether the Zip entry is a valid Zipcode for the City entered.