ci: Validate datasqrl-examples against snapshot images and auto-bump on release#2075
ci: Validate datasqrl-examples against snapshot images and auto-bump on release#2075velo wants to merge 3 commits into
Conversation
…on release Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2075 +/- ##
=========================================
Coverage 13.35% 13.35%
Complexity 841 841
=========================================
Files 606 606
Lines 17516 17516
Branches 2122 2122
=========================================
Hits 2340 2340
Misses 14960 14960
Partials 216 216 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
…ircleCI Signed-off-by: Marvin Froeder <marvin@datasqrl.com>
ferenc-csaky
left a comment
There was a problem hiding this comment.
I don't think this should be executed for every PR or commit that makes it into main.
Ideally that would be nice, but IMO in real life that will be just another annoying step we just skip most of the time, and will be red until we release anyways.
WDYT?
well, if we don't run this on every PR, we will only know it's broken after someone manually checks |
Summary
Two cross-repo CI wiring changes for DataSQRL/datasqrl-examples:
examples-validationjob dispatchesdatasqrl-examples's build workflow with the freshly-built image (ghcr.io/datasqrl/cmd:pr-Nfor PRs,datasqrl/cmd:devfor main) and waits for it to finish. Failures in the examples build now fail this repo's CI.bump-examples-version.ymltriggers onrelease: publishedand opens a PR againstdatasqrl-examplesbumpingSQRL_VERSION(shape matches datasqrl-examples#105). Idempotent — skips if a PR for that version already exists. Also exposed viaworkflow_dispatchfor manual bumps.Supporting change:
build-images— Loosened the halt so PR builds also push toghcr.io/datasqrl/cmd:pr-Nandghcr.io/datasqrl/sqrl-server:pr-N. Without this, downstream CI has nothing to pull on PRs. Tagged releases andmain=:devbehavior on Docker Hub are unchanged.Requirements
BOT_PATsecret in this repo with:contents: write,pull-requests: write,actions: write(dispatch) andactions: read(poll) onDataSQRL/datasqrl-examples.examples-validationjob will fail untildatasqrl-examplesmain has theworkflow_dispatchinputs andrun-name.Notes
ghcr.io/datasqrl/cmdandghcr.io/datasqrl/sqrl-server.cleanup-packages.ymltoday only prunes Maven packages — consider extending it to prune Docker PR tags older than N days (out of scope for this PR).Test plan
BOT_PATsecret is configured in sqrl repoSQRL_VERSION