Skip to content

[WIP] skip _all default partition for RANGE+TTL tables managed by pg_partman #2099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
WellMafra wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[WIP] skip _all default partition for RANGE+TTL tables managed by pg_partman #2099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .../main/java/com/datasqrl/engine/database/relational/ddl/PostgresCreateTableDdlFactory.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,13 @@ public String createTableDdl(CreateTableJdbcStatement stmt) {
return partitionDdl;
}

// pg_partman owns lifecycle for RANGE+TTL tables — no default partition needed
if (stmt.getPartitionType() == PartitionType.RANGE
&& stmt.getTtl() != null
&& !stmt.getTtl().isZero()) {
return partitionDdl;
}

var allPartitionTableName = quoteIdentifier(stmt.getName() + PARTITION_SUFFIX);
var tableName = quoteIdentifier(stmt.getName());
var partitionDefinition =
Expand Down
2 changes: 1 addition & 1 deletion ...ng-integration/src/test/resources/snapshots/com/datasqrl/DAGPlannerTest/partitionTest.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -179,7 +179,7 @@ INSERT INTO `default_catalog`.`default_database`.`Orders_2`
{
"name" : "OrderUpdates_1",
"type" : "TABLE",
"sql" : "CREATE TABLE IF NOT EXISTS \"OrderUpdates_1\" (\"id\" BIGINT NOT NULL, \"customerid\" BIGINT NOT NULL, \"time\" TIMESTAMP WITH TIME ZONE NOT NULL, \"entries\" JSONB, PRIMARY KEY (\"id\",\"time\")) PARTITION BY RANGE (\"time\");\n\nCREATE TABLE IF NOT EXISTS \"OrderUpdates_1_all\" PARTITION OF \"OrderUpdates_1\" FOR VALUES FROM (MINVALUE) TO (MAXVALUE)",
"sql" : "CREATE TABLE IF NOT EXISTS \"OrderUpdates_1\" (\"id\" BIGINT NOT NULL, \"customerid\" BIGINT NOT NULL, \"time\" TIMESTAMP WITH TIME ZONE NOT NULL, \"entries\" JSONB, PRIMARY KEY (\"id\",\"time\")) PARTITION BY RANGE (\"time\")",
"fields" : [
{
"name" : "id",
Expand Down
Loading