Skip to content

Feat/configurable dataset path #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ShuhaoZhangTony merged 3 commits into from
Nov 11, 2025
Merged

Feat/configurable dataset path #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e997900
feat: Make benchmark dataset path configurable
ShuhaoZhangTony Nov 11, 2025
d54366e
refactor: Move benchmark datasets to sageData repository
ShuhaoZhangTony Nov 11, 2025
06f1c2d
ci: Skip dataset copy in CI workflow
ShuhaoZhangTony Nov 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/cmake.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ jobs:
- name: Configure CMake
# Configure CMake in a 'build' subdirectory. `CMAKE_BUILD_TYPE` is only required if you are using a single-configuration generator such as make.
# See https://cmake.org/cmake/help/latest/variable/CMAKE_BUILD_TYPE.html?highlight=cmake_build_type
run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} -DCMAKE_PREFIX_PATH='/usr/local/lib/python3.10/dist-packages/torch/share/cmake'
# Note: Skip dataset copy as datasets are now in sageData repository
run: cmake -B ${{github.workspace}}/build -DCMAKE_BUILD_TYPE=${{env.BUILD_TYPE}} -DCMAKE_PREFIX_PATH='/usr/local/lib/python3.10/dist-packages/torch/share/cmake' -DLIBAMM_SKIP_DATASET_COPY=ON

- name: Build
# Build your program with the given configuration
Expand Down
20 changes: 17 additions & 3 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -163,6 +163,20 @@ file(COPY ${allCopyFiles} DESTINATION ${CMAKE_CURRENT_BINARY_DIR}/benchmark/scri
file(COPY ${allCopyFiles} DESTINATION ${CMAKE_CURRENT_BINARY_DIR}/benchmark/scripts)

# copy files needed for real world matrix loader
set(source_directory "${CMAKE_SOURCE_DIR}/benchmark/datasets/")
set(destination_directory "${CMAKE_BINARY_DIR}/benchmark/datasets/")
file(COPY ${source_directory} DESTINATION ${destination_directory})
# Allow external projects to specify dataset path or disable dataset copy
option(LIBAMM_SKIP_DATASET_COPY "Skip copying benchmark datasets" OFF)
Comment on lines +166 to +167

Copilot AI Nov 11, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These new CMake options lack inline comments explaining their purpose and usage. Consider adding comments above each option to clarify when users should set them (e.g., when using LibAMM as an embedded library vs. standalone).

Suggested change
# Allow external projects to specify dataset path or disable dataset copy
option(LIBAMM_SKIP_DATASET_COPY "Skip copying benchmark datasets" OFF)
# Allow external projects to specify dataset path or disable dataset copy
# Option to skip copying benchmark datasets during installation.
# Set to ON if you do not need the datasets (e.g., when embedding LibAMM or using your own datasets).
option(LIBAMM_SKIP_DATASET_COPY "Skip copying benchmark datasets" OFF)
# Path to the source directory containing LibAMM benchmark datasets.
# Change this if your datasets are located elsewhere, or if you want to use custom datasets.

Copilot uses AI. Check for mistakes.
set(LIBAMM_DATASET_SOURCE_DIR "${CMAKE_SOURCE_DIR}/benchmark/datasets" CACHE PATH "Path to LibAMM benchmark datasets")

if(NOT LIBAMM_SKIP_DATASET_COPY)
if(EXISTS "${LIBAMM_DATASET_SOURCE_DIR}")
message(STATUS "Copying LibAMM datasets from: ${LIBAMM_DATASET_SOURCE_DIR}")
set(source_directory "${LIBAMM_DATASET_SOURCE_DIR}/")
set(destination_directory "${CMAKE_BINARY_DIR}/benchmark/datasets/")
file(COPY ${source_directory} DESTINATION ${destination_directory})
else()
message(STATUS "LibAMM datasets not found at ${LIBAMM_DATASET_SOURCE_DIR}, skipping dataset copy")
message(STATUS "Set LIBAMM_DATASET_SOURCE_DIR to specify a different path, or set LIBAMM_SKIP_DATASET_COPY=ON to disable")

Copilot AI Nov 11, 2025

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The guidance message could be more actionable. Consider specifying the expected sageData repository URL in the message to help users know where to obtain the datasets.

Suggested change
message(STATUS "Set LIBAMM_DATASET_SOURCE_DIR to specify a different path, or set LIBAMM_SKIP_DATASET_COPY=ON to disable")
message(STATUS "Set LIBAMM_DATASET_SOURCE_DIR to specify a different path, or set LIBAMM_SKIP_DATASET_COPY=ON to disable. You can obtain the required datasets from: https://github.com/sage-org/sageData")

Copilot uses AI. Check for mistakes.
endif()
else()
message(STATUS "LibAMM dataset copy disabled (LIBAMM_SKIP_DATASET_COPY=ON)")
endif()
5 changes: 0 additions & 5 deletions benchmark/datasets/AST/README.md
View file
Open in desktop

This file was deleted.

Loading