Removes FailureResult in favor of NoRecords component inside of table view.#152
Merged
scespinoza merged 3 commits intodevelopfrom Jan 29, 2026
Merged
Removes FailureResult in favor of NoRecords component inside of table view.#152scespinoza merged 3 commits intodevelopfrom
scespinoza merged 3 commits intodevelopfrom
Conversation
Member
|
I found a dead end when the filter that cause the no-results state is a Measure filter, and I can’t change it or clear it (control disappears) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SuccessResultcomponent inExplorerResults.tsx, so it no longer displays a failure message when there are no results.NoRecordscomponent inTableView.tsxto use the translated empty result message (results.error_emptyresult_detail) and adjusted its styling for better presentation.