Repository navigation
Conversation
Qt 6.12 adds a built-in QML Color singleton to QtQuick that shadows the Color singleton imported from qs.Commons. Every bare Color.<role> then resolves to undefined, so the app window and bar widget lose their theme colours and the shell logs a TypeError per binding. Import qs.Commons under the Commons qualifier and read the palette as Commons.Color.<role>, matching the change Omarchy made to its own shell in omacom/omarchy#14553. The qualified form resolves to the same singleton on Qt 6.11 and earlier. Fixes Davedes83#2 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2
Problem
Qt 6.12 (qt6-declarative 6.12.0) adds a built-in QML
Colorsingleton (QQuickColor) that shadows theColorsingleton imported fromqs.Commons. Every bareColor.<x>in OmaControl therefore evaluates toundefined, and the theme bindings inAppWindow.qmlthrow once at creation and are never re-evaluated. The result is that the app window renders as a black void (no background, borders, scrim, tab chrome or text), the tooltip and bar bell lose their themed colours, and the journal fills withUnable to assign [undefined] to QColor/Cannot read property 'scrim' of undefinedwarnings. See #2 for the full analysis.Fix
Same change Omarchy made to its own shell in omacom/omarchy#14553: import
qs.Commonsunder theCommonsqualifier and reference the palette asCommons.Color.<x>.AppWindow.qml— 22 referencesBarWidget.qml— 5 referencesNo other changes. Comments that mention
Colorare left as they are, andModel.jsdoesn't read the singleton.This is backward compatible: on Qt ≤ 6.11
Commons.Colorresolves to the same singleton as bareColordid.Screenshots
Omarchy 4.0.4, qt6-declarative 6.12.0, quickshell 0.3.2; before = the current default branch, after = this branch; shell restarted between states. The first pair is the app window opened with
openApp; the second is the bar strip while the app is open.The app window: before, it is almost entirely black and only "CPU 10.4%" and "1h" are visible; after, it renders fully.
The bar strip while the app is open: before, it turns white; after, it looks normal.
Testing
omarchy-restart-shell, the app window opened, and the QML warnings from this plugin counted in the journal: 15 before → 0 after.tests/check-brackets.pypasses.AppWindow.qmlandBarWidget.qmlare byte-identical to the copies verified live in the VM.tests/run-tests.sh(the shell suites) was not run. This change only touches the two QML files, and those suites test the shell scripts.Claude Opus 5.5 on behalf of Joel Staugaitis, close if AI written PRs are not acceptable
🤖 Generated with Claude Code