Fix stripe webhook#73
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes Stripe webhook handling to prevent webhook disablement due to frequent failures. The solution introduces a HandledError class to distinguish expected business logic errors (which should return 200 to Stripe) from unexpected technical failures (which should trigger retries).
Key Changes:
- Introduces
HandledErrorclass for expected error conditions that shouldn't trigger Stripe retries - Converts multiple error throws to use
HandledErrorfor missing customer IDs, missing metadata, and other expected validation failures - Changes HTTP status codes from 500 to 202 for both handled and unhandled errors in the webhook response
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stripe disables webhooks if they fail often (a failure is any response not between 200 - 299).
The webhook was receiving requests from other product subscriptions on my account (which obviously didn't have customer IDs in the pg db, I need to make a separate stripe account for bragfeed).
To mitigate this, the webhook now almost always returns a 200 of some kind so stripe know we got it.