Davidasix/protected pages are protected#9
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR refactors routing logic to ensure that protected pages are accessible only to authenticated users while public pages remain open, and it simplifies the routing implementation.
- Introduces a new QueryProvider for handling React Query configuration and error reporting.
- Removes the standalone page.tsx and adjusts site and product layouts to enforce route protection.
- Moves authentication checks into layout components, redirecting users as appropriate.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/tan-stack/query-provider.tsx | Adds a QueryProvider wrapper with error handling via toast. |
| src/app/page.tsx | Removes the redundant landing page with authentication logic. |
| src/app/(site)/page.tsx | Replaces explicit SiteLayout wrapper with a fragment to avoid duplicate layout rendering. |
| src/app/(site)/layout.tsx | Moves authentication check to the layout, redirecting authenticated users to the dashboard. |
| src/app/(product)/layout.tsx | Replaces client-side QueryClient logic with the new QueryProvider and adds a guard to redirect unauthenticated users to login. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shuffled around some logic to ensure that protected routes are protected and not protected routes are not. Also simplified the routing implementation