commiting csvhead file#1
Open
MariamSh wants to merge 6 commits into
Open
Conversation
onponomarev
reviewed
May 10, 2017
Collaborator
onponomarev
left a comment
onponomarev
left a comment
There was a problem hiding this comment.
Pylint would have detected the unused function:)
So, don't forget to use pylint.
| from argparse import ArgumentParser | ||
| import sys | ||
|
|
||
| DESCRIPTION = 'csvpp - Print header and first lines of input.' |
Collaborator
There was a problem hiding this comment.
Please fix the description
| DESCRIPTION = 'csvpp - Print header and first lines of input.' | ||
| EXAMPLES = 'example: cat file.csv | csvhead -n 100' | ||
|
|
||
| def print_row(row, column_widths, output_stream): |
Collaborator
There was a problem hiding this comment.
You don't use this function.
| Reads line per line and writes it in output_stream. | ||
| """ | ||
| args = parse_args() | ||
| print(args) |
Collaborator
There was a problem hiding this comment.
Please remove this print
| input_stream = open(args.file, 'r') if args.file else sys.stdin | ||
| output_stream = open(args.output_file, 'r') if args.output_file else sys.stdout | ||
|
|
||
| lines = input_stream.readlines() |
Collaborator
There was a problem hiding this comment.
This line loads the whole file into memory. Do you really want it? And what if the file size is 10GB? I guess that it still should be possible to implement low-overhead csvhead.
Collaborator
Author
|
Thank you for replies, I fixed all the notes. Please review them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.