music.html: add multilingual content and translate YouTube section#176
music.html: add multilingual content and translate YouTube section#176
Conversation
…ions and YouTube heading Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/2ed874a1-db1e-42ff-b88e-b11e778937f0 Co-authored-by: DavidKRK <136035295+DavidKRK@users.noreply.github.com>
|
|
There was a problem hiding this comment.
Pull request overview
Improves the usability of the music.html language switcher by adding real per-language page descriptions and making the YouTube section heading translatable via switchLanguage().
Changes:
- Added descriptive paragraphs to each
.lang-contentblock forfr/en/es/eu/ar/uk. - Wrapped the YouTube section heading text in a dedicated element so it can be updated dynamically.
- Extended the
langContenttranslation map with ayoutube_headingkey for all languages and updatedswitchLanguage()accordingly.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ty support Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/147b3a61-c8ad-4cce-8967-446c6397d9f8 Co-authored-by: DavidKRK <136035295+DavidKRK@users.noreply.github.com>
Tout a été vérifié. Un bug a été corrigé (commit |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
#178) * fix: set html lang and dir attributes on language switch for correct RTL rendering Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/045fb7ca-e251-419b-bd87-0c85b16cfc2e Co-authored-by: DavidKRK <136035295+DavidKRK@users.noreply.github.com> * Update music.html Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: DavidKRK <136035295+DavidKRK@users.noreply.github.com> Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
|
@copilot vérifie pourquoi ça marche pas |
… inline styles Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/1392f06a-3278-4510-9e84-5aba038fd1a6 Co-authored-by: DavidKRK <136035295+DavidKRK@users.noreply.github.com>
Le bug était dans Résultat : quand on cliquait sur une langue, Correction : |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ia-post.yml Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/dcbd6b39-5873-47cc-9a33-cb1d146df047 Co-authored-by: DavidKRK <136035295+DavidKRK@users.noreply.github.com>
Les conflits qui bloquaient le merge ont été résolus (commit
Le PR devrait maintenant pouvoir être mergé sans conflit. |
|
Je peux pas Merger @copilot @anthropic-code-agent @anthropic-code-agent |
…e merge conflict Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/4e6c3e68-a8ad-4156-ac12-bdb610e20104 Co-authored-by: DavidKRK <136035295+DavidKRK@users.noreply.github.com>
Le PR est prêt à être mergé. Tous les conflits ont été résolus — vous pouvez maintenant cliquer sur Merge pull request dans GitHub.
Le dernier conflit a été résolu (commit Le merge devrait maintenant fonctionner depuis l'interface GitHub (Merge pull request). |
id="youtube-title-text"to YouTube section heading<span>andid="youtube-section-title"support for auto-injected headingsyoutube_titlekey to each language in thelangContentobjectswitchLanguage()to also update the YouTube section heading (youtube-title-textandyoutube-section-title)switchLanguage()now setsdocument.documentElement.langanddocument.documentElement.dirmain.jswas usingclassList.toggle()+ inlinestyle.displaywhich setdisplay:noneinline on all.lang-contentelements, overriding CSS class-based visibility on every page. Fixed to use properclassList.add/removewith no inline styles.index.html: incorporatedresponsive.csslink and owl image div alongside the language selector.github/workflows/social-media-post.yml: aligned with base branch version to resolve add/add conflictmusic.html: aligned YouTube span ID (youtube-title-text) and key (youtube_title) with changes already ongh-pages(PR fix: translate YouTube section heading on language switch in music.html #175)