Conversation
Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/5d42fd6d-80f7-40cc-a2fe-311924b01ece Co-authored-by: DavidKRK <136035295+DavidKRK@users.noreply.github.com>
|
|
There was a problem hiding this comment.
Pull request overview
Adjusts page-level styling so music.html no longer inherits the body.home-page owl background, by introducing a dedicated music-page body class and corresponding CSS.
Changes:
- Update
music.htmlto use<body class="music-page">instead ofhome-page. - Add a
body.music-pageCSS rule to apply the non-home background and establish a flex column layout for the page.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| music.html | Switches <body> class to music-page to prevent home-page background inheritance. |
| assets/css/style.css | Adds body.music-page styling to control background/layout for the music page. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| </style> | ||
| </head> | ||
| <body class="home-page"> | ||
| <body class="music-page"> |
There was a problem hiding this comment.
The PR description says the owl background is intended only for the home page, but several other pages in the repo still use class="home-page" on <body> (e.g., bio.html, contact.html, event.html, shop.html). If the intent is to restrict the owl background to index.html only, those pages would also need their <body> class updated (or the CSS selector changed to target index.html more specifically).
There was a problem hiding this comment.
@claude[agent] @codex[agent] @snyk-bot @copilot apply changes based on this feedback
There was a problem hiding this comment.
Applied in 04804a0. Updated bio.html, contact.html, event.html, and shop.html to use page-specific classes (bio-page, contact-page, event-page, shop-page).
index.html is the only page that keeps class="home-page" and the owl background. All other pages now fall under body:not(.home-page) which applies the teal background (#416e73) and the flex column layout.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/DavidKRK/DavidKRK.github.io/sessions/a7c79463-e3b3-4a62-94a6-3ba779a4d323 Co-authored-by: DavidKRK <136035295+DavidKRK@users.noreply.github.com>
Several pages were using
class="home-page"on<body>, causing them to inherit thedavid_krk_owl.jpgbackground intended only forindex.html.Changes
music.html: Changed<body class="home-page">→<body class="music-page">bio.html: Changed<body class="home-page">→<body class="bio-page">contact.html: Changed<body class="home-page">→<body class="contact-page">event.html: Changed<body class="home-page">→<body class="event-page">shop.html: Changed<body class="home-page">→<body class="shop-page">assets/css/style.css: Addeddisplay: flex; flex-direction: column;to the existingbody:not(.home-page)rule so all non-home pages maintain their layout; removed the separatebody.music-pagerule (now redundant).body.home-pageandindex.htmlare untouched — the owl background remains exclusive to the home page.