Hard-cut Bloom to TapDB/EUID external reference model#178
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6c7422e265
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| handler_name = f"do_action_{action_name}" | ||
| handler = getattr(self, handler_name, None) | ||
| if not callable(handler): | ||
| raise Exception(f"Unknown action handler {handler_name}") |
There was a problem hiding this comment.
BloomObj.do_action now derives handler_name directly from the action key segment (parts[2]), but many action subtypes are hyphenated (for example plate-create-fill-auto in action configs), so this builds names like do_action_plate-create-fill-auto that cannot match the underscore-based Python methods (do_action_plate_create_fill_auto). In those cases execution now fails with Unknown action handler ..., which breaks a large set of existing actions at runtime.
Useful? React with 👍 / 👎.
| value = str(reference_value or "").strip() | ||
| if not value: | ||
| continue | ||
| validation_payload = atlas_validation.get(reference_type) |
There was a problem hiding this comment.
_replace_external_references looks up validation metadata with atlas_validation.get(reference_type), but reference_type values are order_number/patient_id/shipment_number/kit_barcode while _validate_atlas_refs stores metadata under order/patient/shipment/testkit; this mismatch means each external reference is saved with empty validation payloads and loses provenance about Atlas freshness/cache status.
Useful? React with 👍 / 👎.
1 participant
Summary
Validation