Implement DiscordGateway503Filter for logging - #96
Merged
Merged
Conversation
Added a logging filter to handle Discord Gateway 503 errors.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a targeted logging filter to suppress noisy Discord gateway “503 Service Unavailable” handshake warnings and replace them with a single cleaner warning emitted by the application logger.
Changes:
- Introduces
DiscordGateway503Filterto detect Discord gateway 503 handshake failures and rewrite the log output. - Registers the filter on the
discord.clientlogger duringmain()startup.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
src/fablabot/main.py:58
- Logging a new message from inside a logging filter adds side effects and can lead to confusing ordering or re-entrancy issues. Since the goal is just to de-noise this specific 503 warning, it’s safer to rewrite the existing record (and clear exc_info) and let the original logger emit it, rather than emitting a second log and returning False.
logger.warning(
"Discord Gateway indisponible (503). %s",
retry_message,
)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a logging filter to handle Discord Gateway 503 errors.