Skip to content

feat(priwa): unify mobile map controls - #573

Merged
JesJehle merged 1 commit into
mainfrom
feat/priwa-unified-map-controls
Sep 2, 2026
Merged

feat(priwa): unify mobile map controls#573
JesJehle merged 1 commit into
mainfrom
feat/priwa-unified-map-controls

Conversation

@JesJehle

@JesJehle JesJehle commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

Briefing

This simplifies PRIWA mobile map controls around two non-blocking bottom sheets: one for offline maps and one for map layers. It keeps the map visible while users inspect downloaded coverage, select another square area, switch the basemap, or control the Warnkarte, and moves the two primary field actions into one consistent bottom-right stack. The reusable sheet and compact layer cards also improve the DeadTrees mobile layer panel.

What changed

  • Consolidated mobile basemap and Warnkarte controls into one draggable, dismissible layers sheet, with explicit Warnkarte visibility and zoom actions.
  • Moved offline management and area selection into compact bottom sheets while preserving the centered square download frame and existing coverage polygons.
  • Replaced independent panel booleans with one mutually exclusive panel state for layers, offline maps, and the mobile tree list.
  • Moved add-tree and locate actions to equal-sized bottom-right buttons; the left stack now contains only layers and the tree list.
  • Made Warnkarte load failures action-scoped and temporary, while retaining an explicit desktop retry path.

Validation

  • npm --prefix frontend test — 67 files and 333 tests passed.
  • npm --prefix frontend run lint — passed.
  • npm --prefix frontend run build — passed; only the existing chunk-size warning remains.
  • scripts/lint-ast-grep.sh — passed.
  • playwright.local.config.ts e2e-local/priwa-warnkarte-local.spec.ts — all 9 mocked Warnkarte desktop, tablet, and mobile journeys passed.
  • npm --prefix frontend run test:e2e:local:priwa:write — all 4 isolated Supabase/PWA offline write and sync journeys passed.
  • iPhone-size screenshots at 393 x 852 were inspected for the compact layers sheet, primary action placement, offline management sheet, and centered square selection; a separate DeadTrees mobile layers screenshot confirmed the shared compact cards.
  • Thermonuclear review and the second/final Codex autoreview found no remaining P0/P1 blocker.

Risk and limitations

This changes mobile control placement and the initial sheet height, and changes the shared DeadTrees mobile layer sheet to open compactly. It does not change offline tile limits, cached data formats, database schema, API contracts, or Warnkarte data.

Reviewer guide

Please focus on the shared bottom-sheet drag/snap behavior, the single active-panel state in PRIWA, and the explicit Warnkarte retry behavior when the initial overlay request fails.

@JesJehle JesJehle added the frontend Frontend changes label Sep 2, 2026
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 2, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-02T10:22:13.135334Z 95f1377 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@github-actions

github-actions Bot commented Sep 2, 2026

Copy link
Copy Markdown

Frontend preview

Open Firebase preview

Channel: pr573-feat-priwa-unified-map-c
Commit: 95f13774847395e780b23ad05f5c712e7dc0f7c2

@JesJehle
JesJehle merged commit ef24f33 into main Sep 2, 2026
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend Frontend changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant