feat(priwa): unify mobile map controls - #573
Merged
Merged
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Frontend previewChannel: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Briefing
This simplifies PRIWA mobile map controls around two non-blocking bottom sheets: one for offline maps and one for map layers. It keeps the map visible while users inspect downloaded coverage, select another square area, switch the basemap, or control the Warnkarte, and moves the two primary field actions into one consistent bottom-right stack. The reusable sheet and compact layer cards also improve the DeadTrees mobile layer panel.
What changed
Validation
npm --prefix frontend test— 67 files and 333 tests passed.npm --prefix frontend run lint— passed.npm --prefix frontend run build— passed; only the existing chunk-size warning remains.scripts/lint-ast-grep.sh— passed.playwright.local.config.ts e2e-local/priwa-warnkarte-local.spec.ts— all 9 mocked Warnkarte desktop, tablet, and mobile journeys passed.npm --prefix frontend run test:e2e:local:priwa:write— all 4 isolated Supabase/PWA offline write and sync journeys passed.Risk and limitations
This changes mobile control placement and the initial sheet height, and changes the shared DeadTrees mobile layer sheet to open compactly. It does not change offline tile limits, cached data formats, database schema, API contracts, or Warnkarte data.
Reviewer guide
Please focus on the shared bottom-sheet drag/snap behavior, the single active-panel state in PRIWA, and the explicit Warnkarte retry behavior when the initial overlay request fails.