Skip to content

fix(middleware): track actual response size #127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
georgidhristov merged 1 commit into from
Jun 21, 2026
+4 −1
Merged

fix(middleware): track actual response size #127

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions DebugProbe.AspNetCore.Tests/Middleware/ResponseBodyCaptureTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ public async Task Handles_large_response_within_limit()
await app.Client.GetAsync("/large");

Assert.Equal(body, app.SingleEntry.ResponseBody);
Assert.Equal(body.Length, app.SingleEntry.ResponseSize);
}

[Fact]
Expand All @@ -54,6 +55,7 @@ public async Task Handles_binary_response_safely()
await app.Client.GetAsync("/binary");

Assert.Equal("[Body not captured: non-text content]", app.SingleEntry.ResponseBody);
Assert.Equal(4, app.SingleEntry.ResponseSize);
}

[Fact]
Expand All @@ -69,5 +71,6 @@ public async Task Validates_bounded_response_capture_behavior()
var entry = app.SingleEntry;
Assert.Equal(body, await response.Content.ReadAsStringAsync());
Assert.Equal("[Body too large]", entry.ResponseBody);
Assert.Equal(body.Length, entry.ResponseSize);
}
}
2 changes: 1 addition & 1 deletion DebugProbe.AspNetCore/Middleware/DebugProbeMiddleware.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ public async Task Invoke(HttpContext context, DebugEntryStore store)

entry.RequestSize = context.Request.ContentLength ?? Encoding.UTF8.GetByteCount(requestBody);

entry.ResponseSize = Encoding.UTF8.GetByteCount(responseBody);
entry.ResponseSize = responseCapture.TotalBytesWritten;

entry.RequestHeaders =
context.Request.Headers.ToDictionary(
Expand Down
Loading