Skip to content

Consensus hardening: strict certificate verification - #12

Merged
NeonTechno merged 6 commits into
mainfrom
feat/consensus-hardening
Oct 27, 2026
Merged

NeonTechno merged 6 commits into
mainfrom
feat/consensus-hardening

Conversation

@NeonTechno

@NeonTechno NeonTechno commented Oct 20, 2026 •

Copy link
Copy Markdown
Contributor

Summary

  • Strictly validate every vote in a commit certificate; reject duplicate, unknown, malformed, or invalidly signed votes.
  • Validate block metadata before accepting a certificate and defensively copy signatures when building commit certificates.
  • Add tests for duplicate votes, unknown validators, malformed signatures, invalid block metadata, and insufficient quorum.

Scope

This PR targets the existing experimental consensus implementation only. It does not add production BFT, peer propagation, view changes, or endpoint authentication. CI must pass before merge; tests have not been run in this environment.


View with [code]smith Autofix with [code]smith
Need help on this PR? Tag @codesmith-bot with what you need.

@NeonTechno
NeonTechno marked this pull request as ready for review October 27, 2026 12:19
@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ⚠️ Failed 2026-10-27T12:19:33.580833Z
We couldn’t complete this review. Comment @codex review to try again.
65013c0 Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@NeonTechno
NeonTechno merged commit 0e95100 into main Oct 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant