Skip to content

Fix golangci-lint issues#84

Open
redbeam wants to merge 2 commits into
DeedleFake:masterfrom
redbeam:fix-golangci-lint-issues
Open

Fix golangci-lint issues#84
redbeam wants to merge 2 commits into
DeedleFake:masterfrom
redbeam:fix-golangci-lint-issues

Conversation

@redbeam

@redbeam redbeam commented Nov 6, 2025

Copy link
Copy Markdown
Contributor

Fixes golangci-lint issues; they're mostly about checking Fprintf for errors and handling errors in deferred functions.

@DeedleFake

DeedleFake commented Nov 7, 2025

Copy link
Copy Markdown
Owner

Thank you for the pull request.

I do not want all of those extra _, _ = before every single Fprint*() call. I do not agree with golangci-lint on this in the slightest.

The defer changes and the embedded redundancy removal are probably fine. Remove the _, _ and I'll take another look.

@redbeam redbeam force-pushed the fix-golangci-lint-issues branch from 516aae5 to 372c809 Compare November 10, 2025 14:55
@redbeam

redbeam commented Nov 10, 2025

Copy link
Copy Markdown
Contributor Author

Yeah, I get your point. The other option would be to silence them using //nolint:errcheck, but I'm not sure if that's any better.

Anyway, I dropped the commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants