Conversation
There was a problem hiding this comment.
Pull request overview
Updates fsqc to use the upcoming headless rendering behavior in whippersnappy 2.1.0 (removing the need for xvfb/xvfb-run), and aligns documentation and container dependencies accordingly.
Changes:
- Update dependency to
whippersnappy==2.1.0and adjustViewTypeimport location. - Remove
xvfb-runfrom the Singularity usage docs. - Replace
xvfb/EGL-related system packages in the Docker image with Mesa software-rendering/OpenGL libs.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
singularity/Singularity.md |
Removes xvfb-run from the Singularity execution example and updates the explanatory bullet. |
requirements.txt |
Pins whippersnappy to 2.1.0. |
fsqc/createSurfacePlots.py |
Updates ViewType import to match the new whippersnappy API. |
docker/Dockerfile |
Drops xvfb and swaps OpenGL-related OS deps to support headless rendering. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: kdiers <24712358+kdiers@users.noreply.github.com>
|
will wait until whippersnappy 2.1 is released. |
|
Also includes a revision of how we define and build Docker images, primarily via an updated Dockerfile. |
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 9 out of 11 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
.github/workflows/build.yml
Outdated
| matrix: | ||
| os: [ubuntu, macos, windows] | ||
| python-version: ["3.9", "3.10", "3.11", "3.12"] | ||
| python-version: ["3.10", "3.11", "3.12"] |
There was a problem hiding this comment.
Here (and everywhere else, other workflows, pyproject.toml) I would include 3.13 now that 3.9 is dropped.
There was a problem hiding this comment.
you can even consider running the workflows with 3.13 as it will be faster.
.flake8
Outdated
| @@ -0,0 +1,23 @@ | |||
| [flake8] | |||
There was a problem hiding this comment.
why is flake8 file here ? we usually use ruff and also put all config information into pyproject.toml so that it is in one place and not distributed in many files.
|
you can also remove the empty codespellignore , then update the workflows that use code spell. You can setup code spell in pyproject.toml rather then passing parameters at runtime in the workflows (see whippersnappy and lapy for it). |
|
Ready to merge into dev @m-reuter |
Update to upcoming whippersnappy 2.1.0, which no longer requires using xvfb for off-screen rendering.