Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds 7-DoF (similarity) and 9-DoF (rigid + anisotropic scale, no shear) transform models to segreg, extending centroid-based registration beyond rigid/affine while updating docs/CLI and adding solver + integration tests.
Changes:
- Implement
find_similarityandfind_rigid_anisotropic_scalesolvers and route them viaregister_points(dof=7|9). - Extend
segreg()and thesegregCLI to accept DoF{6,7,9,12}and update defaults/docs accordingly. - Add unit/integration tests for the new solvers and
segreg()DoF modes; update README.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
neuroreg/segreg/points.py |
Adds similarity + anisotropic no-shear solvers and DoF dispatch. |
neuroreg/segreg/register.py |
Expands segreg() DoF support and updates min-label defaults/docs. |
neuroreg/cli/segreg.py |
Updates CLI --dof choices and help text to include 7/9. |
tests/test_segreg.py |
Adds tests covering DoF 7/9 in both point solvers and segreg(). |
README.md |
Documents new DoF support and updates the support table. |
neuroreg/segreg/{__init__.py,atlas.py,centroids.py,io.py,labels.py} |
Docstring/description updates to reflect expanded functionality. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.