Make frontend self-hosting independent from hardcoded API host IPs - #30
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
/apito the internal backend service.Description
frontend/nginx.confadded to serve the built Vite SPA from/usr/share/nginx/htmland proxy/api/tohttp://backend:8000/api/and/healthtohttp://backend:8000/healthwith SPAtry_filesfallback.frontend/Dockerfileupdated to makeVITE_API_URLbuild-arg optional and to copy the newnginx.confinto the runtime Nginx stage while keepingEXPOSE 80.docker-compose.ymlanddocker-compose.prod.ymlcleaned to remove hardcoded192.168.x.xentries and to stop injectingVITE_API_URLinto the frontend build; backendCORS_ORIGINSnow uses configurable localhost defaults..env.exampleupdated to documentVITE_API_URLas optional (empty for same-origin proxy) and to provide sensibleCORS_ORIGINSdefaults, andREADME.mdplusdocs/operations/reverse-proxy.mdwere updated to document the new default networking (recommended Variant A: external proxy ->frontend:80).frontend/src/api.tsalready supported an emptyVITE_API_URLand therefore remained unchanged.Testing
cd backend && pytest -qand succeeded:73 passed.cd frontend && npm run buildand succeeded (Vite build completed).docker compose config/docker compose upcould not be executed in this environment because Docker is not installed (docker: command not found).Codex Task