v0.7.2-beta: ROA Planner / ROA Preflight - #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
prefix+origin_as(+ optionalmax_length) against RPKI data and get explainable suggestions without any writes.Description
RoaPlannerService(backend/app/services/roa_planner_service.py) which usesRipeStatClientto evaluate matching/conflicting ROAs, computeplanned_validation_state, flagmax_lengthrisks and producesuggested_roa,matching_roas,conflicting_roas,recommendationsandsource_diagnostics.POST /api/check/roa-preflightimplemented inbackend/app/api/routes_checks.pywith request schemaRoaPreflightCheckRequestinbackend/app/schemas.py, authorization using the existing operator/admin role guard, reuse of existing check/report persistence and change-case attachment logic, and audit eventroa_preflight_checked.runRoaPreflightCheckinfrontend/src/api.ts, a ROA Planner UI formfrontend/src/components/RoaPlannerForm.tsx, navigation entry infrontend/src/components/Layout.tsx, App routing infrontend/src/App.tsx, and Change Case integration to run ROA preflight from case details.v0.7.2-betaand updatedREADME.md,ROADMAP.mdandRELEASE_NOTES.mdto reflect the release and feature.Testing
cd backend && pytest -q; test suite passed (99 passedin this environment) and new tests for ROA preflight (role checks, viewer forbidden, suggested ROA, invalidmax_length, change-case 404 and attachment, and audit emission) were added tobackend/tests/test_api_smoke.py.cd frontend && npm run build; the production build completed successfully (vite build succeeded, with a non-blocking npm env warning).Codex Task