-
Notifications
You must be signed in to change notification settings - Fork 142
Add Icons&compinfo #1357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add Icons&compinfo #1357
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added compinfo for apps: 8-bit wonders, e-albania, jconnect mobile, old wild west, preply, sms virtual
Contributor
Author
|
I forgot about the underscore thing my bad 😭 |
Collaborator
|
Jconnect mobile: center icon Old Wild West: center text Preply: center icon SMS virtual: remove gradient (I'll miss it... :<)
I thought that the suggestion that @flameshikari gave me on Discord was pretty important for newcomers, so I tried adding it in the contribs. Hope this doesn't disrupt anything too big. Here is the original message link: `https://discord.com/channels/743783969216135198/1075048045084934155/1467493888187961502`
seems like I was uploading files from the wrong folder ALL THE TIME. Sorry, I feel dumb right now I shouldn't make such mistakes
Collaborator
|
also update names with hyphens in icons.yml |
make icons 176x176, not 177x177
just got a printer and had to install this app, at least I want it skinned :>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains icons and their compinfo added in
/contribs/icons/and/contribs/icons.ymlrespectively. These were all from therequests.ymlfile.Icons added are: