Waq/feature/delwaq 1268 add organic matter dependency#987
Open
arjenmarkusdeltaresnl wants to merge 6 commits into
Open
Waq/feature/delwaq 1268 add organic matter dependency#987arjenmarkusdeltaresnl wants to merge 6 commits into
arjenmarkusdeltaresnl wants to merge 6 commits into
Conversation
Provide a first implementation of the influence of organic material on the settling of inorganic material. This is likely not to be the definitive version, as I have a bunch of questions about the proposed change.
michelle-deltares
requested changes
Jun 25, 2026
michelle-deltares
left a comment
michelle-deltares
left a comment
Contributor
There was a problem hiding this comment.
See JIRA for my fundamental question about the equation
The drawback of the expression 1+(pom/pom_crit)**n is that with POM in the neighbourhood of the critical concentration, you have twice the settling velocity. The max() function is less elegant (bend) but it does not have this doubling.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What was done
Evidence of the work done
<add video/figures if applicable>
Tests
<add testcase numbers if applicable, Issue number>
Documentation
<add description of changes if applicable, Issue number>
Issue link